From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752360AbbBXEAD (ORCPT ); Mon, 23 Feb 2015 23:00:03 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35524 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbbBXEAA (ORCPT ); Mon, 23 Feb 2015 23:00:00 -0500 Date: Mon, 23 Feb 2015 19:59:56 -0800 From: Brian Norris To: Viet Nga Dao Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, nga_chi86 Subject: Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver Message-ID: <20150224035956.GE18140@ld-irv-0074> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao wrote: > Hi, > It has been nearly 2 weeks since i submitted this patch. Could you > please help to review? Those two weeks were during the merge window, so I wasn't queueing anything up. And there are things that have waited longer, anyway. My time is unfortunately finite. I'll get to your patch eventually. > On Tue, Feb 17, 2015 at 9:33 AM, Viet Nga Dao wrote: > > Hi Brian, > > Could you please help me to review through this 2nd version? > > > > On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote: > >> From: Viet Nga Dao > >> > >> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and > >> EPCS flash chips. This patch adds driver for these devices. > >> > >> Signed-off-by: VIET NGA DAO > >> > >> --- > >> v2: > >> - Change to spi_nor structure > >> - Add lock and unlock functions for spi_nor > >> - Simplify the altera_epcq_lock function > >> - Replace reg by compatible in device tree ... Brian