From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756700AbbCCTju (ORCPT ); Tue, 3 Mar 2015 14:39:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36732 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755711AbbCCTjs (ORCPT ); Tue, 3 Mar 2015 14:39:48 -0500 Date: Tue, 03 Mar 2015 14:39:45 -0500 (EST) Message-Id: <20150303.143945.661201418308735762.davem@davemloft.net> To: joestringer@nicira.com Cc: netdev@vger.kernel.org, pshelar@nicira.com, linux-kernel@vger.kernel.org, jrajahalme@nicira.com Subject: Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions. From: David Miller In-Reply-To: <1425350996-2930-1-git-send-email-joestringer@nicira.com> References: <1425350996-2930-1-git-send-email-joestringer@nicira.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 11:39:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Stringer Date: Mon, 2 Mar 2015 18:49:56 -0800 > Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside > of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions > back to regular set actions, the inner attribute length was not changed, > ie, double the length being serialized. This patch fixes the bug. > > Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.") > Signed-off-by: Joe Stringer > --- > This fix needs to be applied to net as well; it applies cleanly. This is backwards, don't do this. Just say that 'net' needs the fix and submit it targetting that tree only. Things in 'net' propagate into 'net-next' automatically as I do merges over time, but the opposite is not true.