From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbbCCHUH (ORCPT ); Tue, 3 Mar 2015 02:20:07 -0500 Received: from down.free-electrons.com ([37.187.137.238]:59761 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752115AbbCCHUF (ORCPT ); Tue, 3 Mar 2015 02:20:05 -0500 Date: Tue, 3 Mar 2015 08:17:27 +0100 From: Maxime Ripard To: Thomas =?iso-8859-1?Q?Niederpr=FCm?= Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 01/10] fbdev: ssd1307fb: fix memory address smem_start. Message-ID: <20150303071727.GD4713@lukather> References: <1423261694-5939-1-git-send-email-niederp@physik.uni-kl.de> <1425248883-25367-1-git-send-email-niederp@physik.uni-kl.de> <1425248883-25367-2-git-send-email-niederp@physik.uni-kl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rqzD5py0kzyFAOWN" Content-Disposition: inline In-Reply-To: <1425248883-25367-2-git-send-email-niederp@physik.uni-kl.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rqzD5py0kzyFAOWN Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 01, 2015 at 11:27:54PM +0100, Thomas Niederpr=FCm wrote: > the smem_start pointer of the framebuffer info struct needs to hold the > physical address rather than the virtual address. This patch fixes a > driver crash on mmaping the framebuffer memory due to an access to the > memory address. >=20 > Note however that the memory allocated by kzalloc is not page aligned, > while the address presented on a mmap call is aligned to the next page > boudary. >=20 > Signed-off-by: Thomas Niederpr=FCm Acked-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --rqzD5py0kzyFAOWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU9WAHAAoJEBx+YmzsjxAgGckQAJbPcdQVdA+gkGiqYHFat+Qr XE2SAxrE/Cj7ll6EhrrzSvw/BokoTbSq8GFf2svypWu2N/IgbNPEFnKb9O5f+ruC K1uI3T6RkQWlDzXwAG8HfV6ZWuGSb7dYMFAbwvwCq74BKd15vNVneT1fGjNKBgsv PcNmGtry+Udgift/4g7uTsSeGWBR84RP2eW6bAe4SHgh+QSk2Cv1UiHcy2FjGheD 1AFWzUW/lg7zKjqUn1EUqzaE2BKmTyuqsVw0DA+ahtaaZcOMS+HlEW6SF4pSrJHo /mzd0GONQ7fHMGXG883EiYItsU2jx5K/CRAZqnOqsblb8dUugnDlpmWKusGSNl+s 594kDnRcyFfnrh5KU4YQncNvsTuYjJIUYGVI6bCMXfMl4T+B4MtOJZcG3diMWE6Q XZTKlw4+y8RV5M/ROdG+MhX5k42Ht8B3QPLMScDtBUJiHKoO4z09lMD+WrHhxsR3 xayJuuCLBB6uwPKwRKDP0GNGfa6DFJ9CX5UaEHzSxmYQRzm4WxDrLSFSeG2yXLSJ P0QiCWKzyf972gmPSKukSBO4pSMGQo+mMIjNeja84DbZvrvkj/87aqIVU+KnSkyY BGqNKy56X2U4tKVguj0mjxVyyKICiKVrtrH8puUhaWExisRrsndX1J7vMSHuAUkp WgEIP3WMZ71FXeLR/LT0 =1NGU -----END PGP SIGNATURE----- --rqzD5py0kzyFAOWN--