From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760016AbbCDKb5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 05:31:57 -0500
Received: from mail.skyhub.de ([78.46.96.112]:38436 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758605AbbCDKby (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 05:31:54 -0500
Date: Wed, 4 Mar 2015 11:30:39 +0100
From: Borislav Petkov <bp@alien8.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tavis Ormandy <taviso@google.com>, Ingo Molnar <mingo@kernel.org>,
        Rik van Riel <riel@redhat.com>, Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/regsets: change xstateregs_get/set to use
 ->xsave.i387 rather than ->fxsave
Message-ID: <20150304103039.GA3516@pd.tnic>
References: <CAJ_zFkJkHpU4Y8wrrZjO0VnhzUVqJfyrLmNfRsBRT29bgbDSHg@mail.gmail.com>
 <20150301184650.GA12758@redhat.com>
 <20150301185943.GA14318@redhat.com>
 <20150302174818.GA16886@redhat.com>
 <20150302183210.GA23085@redhat.com>
 <20150302183237.GB23085@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150302183237.GB23085@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 02, 2015 at 07:32:37PM +0100, Oleg Nesterov wrote:
> Cosmetic. xstateregs_get() and xstateregs_set() abuse ->fxsave to access
> xsave->i387.sw_reserved. This is correct, ->fxsave and xsave->i387 share
> the same memory, but imho this looks confusing.
> 
> And we can make this code more readable if we add "struct xsave_struct *"
> local.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--