From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759183AbbCDLVc (ORCPT ); Wed, 4 Mar 2015 06:21:32 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:42574 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755386AbbCDLVa (ORCPT ); Wed, 4 Mar 2015 06:21:30 -0500 Date: Wed, 4 Mar 2015 12:21:09 +0100 From: Sascha Hauer To: "pi-cheng.chen" Cc: Mike Turquette , Stephen Boyd , Matthias Brugger , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Henry Chen , James Liao , fan.chen@mediatek.com, Eddie Huang , "Joe.C" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linaro-kernel@lists.linaro.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] clk: mediatek: Export CPU mux clocks for CPU frequency control Message-ID: <20150304112109.GB11010@pengutronix.de> References: <1425466152-7867-1-git-send-email-pi-cheng.chen@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425466152-7867-1-git-send-email-pi-cheng.chen@linaro.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:55:11 up 3 days, 23:08, 44 users, load average: 0.03, 0.03, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 06:49:11PM +0800, pi-cheng.chen wrote: > This patch adds CPU mux clocks which are used by Mediatek cpufreq driver > for intermediate clock source switching. This patch is based on Mediatek > clock driver patches[1]. > > [1] http://thread.gmane.org/gmane.linux.kernel/1892436 > > Signed-off-by: pi-cheng.chen > --- > +static long clk_cpumux_determine_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long min_rate, > + unsigned long max_rate, > + unsigned long *best_parent_rate, > + struct clk_hw **best_parent_p) > +{ > + struct clk *clk = hw->clk, *parent; > + unsigned long parent_rate; > + int i; > + > + for (i = MAINPLL_INDEX; i >= ARMPLL_INDEX; i--) { > + parent = clk_get_parent_by_index(clk, i); > + if (!parent) > + return 0; > + > + if (i == MAINPLL_INDEX) { > + parent_rate = __clk_get_rate(parent); > + if (parent_rate == rate) > + break; > + } > + > + parent_rate = __clk_round_rate(parent, rate); > + } > + > + *best_parent_rate = parent_rate; > + *best_parent_p = __clk_get_hw(parent); > + return parent_rate; > +} Why this determine_rate hook? If you want to switch the clock to some intermediate parent I would assume you do this explicitly by setting the parent and not implicitly by setting a rate. > +int mtk_clk_register_cpumuxes(struct device_node *node, > + struct mtk_composite *clks, int num, > + struct clk_onecell_data *clk_data) > +{ > + int i; > + struct clk *clk; > + struct regmap *regmap; > + > + if (!clk_data) > + return -ENOMEM; > + > + regmap = syscon_node_to_regmap(node); > + if (IS_ERR(regmap)) { > + pr_err("Cannot find regmap for %s: %ld\n", node->full_name, > + PTR_ERR(regmap)); > + return PTR_ERR(regmap); > + } > + > + for (i = 0; i < num; i++) { > + struct mtk_composite *mux = &clks[i]; > + > + clk = mtk_clk_register_cpumux(mux->name, mux->parent_names, > + mux->num_parents, regmap, > + mux->mux_reg, mux->mux_shift, > + mux->mux_width); Pass 'mux' directly instead of dispatching this struct into the individual fields. Also, probably better to move this function to drivers/clk/mediatek/clk-cpumux.c Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |