From: Tony Lindgren <tony@atomide.com>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
Suman Anna <s-anna@ti.com>, Kevin Hilman <khilman@linaro.org>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: am33xx: Move wkup_m3 node to soc node and add ranges
Date: Thu, 5 Mar 2015 07:40:39 -0800 [thread overview]
Message-ID: <20150305154039.GD13520@atomide.com> (raw)
In-Reply-To: <1425528742-3087-3-git-send-email-d-gerlach@ti.com>
* Dave Gerlach <d-gerlach@ti.com> [150304 20:14]:
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index acd3705..086415c 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -77,10 +77,23 @@
> */
> soc {
> compatible = "ti,omap-infra";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x44d00000 0x4000>,
> + <0x80000 0x44d80000 0x2000>;
> +
I think putting the ranges here will cause issues for adding
ranges for anything else.
How about do something like this instead (untested):
ocp {
l4_wkup: l4_wkup@44c00000 {
compatible = "am335-l4-wkup", "simple-bus";
ranges = <0 0x44c00000 0x3fffff>;
wkup_m3: wkup_m3@44d00000 {
compatible = "ti,am3353-wkup-m3";
reg = <0x1000000 0x4000>, /* M3 UMEM */
<0x180000 0x2000>; /* M3 DMEM */
ti,hwmods = "wkup_m3";
ti,pm-firmware = "am335x-pm-firmware.elf";
};
...
};
};
That way we can start moving also the other l4_wkup components there
eventuallly without having to redo the ranges again for wkup_m3.
You can also look at how the scm_conf was done for dm816x.dtsi for an
example, and the recent large set of patches posted by Tero.
Regards,
Tony
next prev parent reply other threads:[~2015-03-05 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 4:12 [PATCH v2 0/2] ARM: OMAP2+: wkup_m3_rproc support patches Dave Gerlach
2015-03-05 4:12 ` [PATCH v2 1/2] ARM: OMAP2+: Use pdata-quirks for wkup_m3 deassert_hardreset Dave Gerlach
2015-03-05 4:12 ` [PATCH v2 2/2] ARM: dts: am33xx: Move wkup_m3 node to soc node and add ranges Dave Gerlach
2015-03-05 15:40 ` Tony Lindgren [this message]
2015-03-05 16:46 ` Suman Anna
2015-03-05 16:57 ` Tony Lindgren
2015-03-09 23:59 ` Suman Anna
2015-03-10 16:09 ` Tony Lindgren
2015-03-10 19:55 ` Dave Gerlach
2015-03-11 16:26 ` Tony Lindgren
2015-03-11 17:18 ` Suman Anna
2015-03-11 17:32 ` Tony Lindgren
2015-03-11 19:18 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305154039.GD13520@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).