From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755236AbbCFSGp (ORCPT ); Fri, 6 Mar 2015 13:06:45 -0500 Received: from foss.arm.com ([217.140.101.70]:60726 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462AbbCFSGn (ORCPT ); Fri, 6 Mar 2015 13:06:43 -0500 Date: Fri, 6 Mar 2015 18:06:36 +0000 From: Lorenzo Pieralisi To: Hanjun Guo Cc: Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Olof Johansson , "grant.likely@linaro.org" , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Tomasz Nowicki Subject: Re: [PATCH v9 12/21] ACPI / table: Print GIC information when MADT is parsed Message-ID: <20150306180636.GB26888@e102568-lin.cambridge.arm.com> References: <1424853601-6675-1-git-send-email-hanjun.guo@linaro.org> <1424853601-6675-13-git-send-email-hanjun.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424853601-6675-13-git-send-email-hanjun.guo@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 08:39:52AM +0000, Hanjun Guo wrote: > When MADT is parsed, print GIC information as debug message: > > ACPI: GICC (acpi_id[0x0000] address[00000000e112f000] MPIDR[0x0] enabled) > ACPI: GICC (acpi_id[0x0001] address[00000000e112f000] MPIDR[0x1] enabled) > ... > ACPI: GICC (acpi_id[0x0201] address[00000000e112f000] MPIDR[0x201] enabled) > > Those debug information will be very helpful to bring up early systems to > see if acpi_id and MPIDR are matched or not as spec defined. Nit: "This debug information" > CC: Rafael J. Wysocki > Tested-by: Suravee Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Acked-by: Sudeep Holla > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki Acked-by: Lorenzo Pieralisi > --- > drivers/acpi/tables.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index f4e5b88..2e19189 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -185,6 +185,28 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) > } > break; > > + case ACPI_MADT_TYPE_GENERIC_INTERRUPT: > + { > + struct acpi_madt_generic_interrupt *p = > + (struct acpi_madt_generic_interrupt *)header; > + pr_debug("GICC (acpi_id[0x%04x] address[%llx] MPIDR[0x%llx] %s)\n", > + p->uid, p->base_address, > + p->arm_mpidr, > + (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); > + > + } > + break; > + > + case ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR: > + { > + struct acpi_madt_generic_distributor *p = > + (struct acpi_madt_generic_distributor *)header; > + pr_debug("GIC Distributor (gic_id[0x%04x] address[%llx] gsi_base[%d])\n", > + p->gic_id, p->base_address, > + p->global_irq_base); > + } > + break; > + > default: > pr_warn("Found unsupported MADT entry (type = 0x%x)\n", > header->type); > -- > 1.9.1 > >