From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbbCFVJR (ORCPT ); Fri, 6 Mar 2015 16:09:17 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51958 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbbCFVJQ (ORCPT ); Fri, 6 Mar 2015 16:09:16 -0500 Date: Fri, 6 Mar 2015 22:09:09 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Stephen Boyd Cc: Mike Turquette , linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?S=F6ren?= Brinkmann , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 0/3] clk: divider: three exactness fixes (and a rant) Message-ID: <20150306210909.GI10717@pengutronix.de> References: <20150221085620.GV19388@pengutronix.de> <1424515225-6929-1-git-send-email-u.kleine-koenig@pengutronix.de> <20150306185730.11109.45998@quantum> <54FA0385.2060808@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54FA0385.2060808@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2015 at 11:44:05AM -0800, Stephen Boyd wrote: > On 03/06/15 10:57, Mike Turquette wrote: > > > > Uwe, > > > > Thanks for the fixes. I'm thinking of taking all three for 4.0. I also > > agree on clk_round_rate_nearest (along with a _ceil and _floor version > > as well). That's something we can do for 4.1 probably. > > > > There are currently 3 users of CLK_DIVIDER_ROUND_CLOSEST: > > > > Loongson > > QCOM > > ST > > > > So now is probably the right time to remove the flag if we're going to > > do it. > > > > What do you think? > > > > I may have had to do divider round closest on qcom platforms because of > the problem these patches are for. I'll have to go back and look. When you do that, also check if it works for you. I think the implementation is broken for most of the cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |