From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755415AbbCFWkj (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 17:40:39 -0500
Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:39030 "EHLO
	atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753568AbbCFWkh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 17:40:37 -0500
Date: Fri, 6 Mar 2015 23:40:34 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        ivo.g.dimitrov.75@gmail.com, Samuel Ortiz <sameo@linux.intel.com>,
        khilman@kernel.org, NeilBrown <neilb@suse.de>, sre@debian.org,
        linux-pm@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        Sebastian Reichel <sre@kernel.org>,
        GTA04 owners <gta04-owner@goldelico.com>, sre@ring0.de,
        Tony Lindgren <tony@atomide.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>, patrikbachan@gmail.com,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: twl4030_charger: need changes to get probed?
Message-ID: <20150306224034.GA20559@amd>
References: <20150224043341.4243.23291.stgit@notabene.brown>
 <20150305173350.50502b95@notabene.brown>
 <20150306212417.GA24169@amd>
 <201503062257.58180@pali>
 <CANOLnONUtfF1UwgW3O5fkAX30UMznZXwbtPkqPFDLR4jFdNqow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANOLnONUtfF1UwgW3O5fkAX30UMznZXwbtPkqPFDLR4jFdNqow@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote:
> On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > On Friday 06 March 2015 22:24:17 Pavel Machek wrote:
> >> Hi!
> >>
> >> According to n900 dts, twl4030-bci (aka charger) should be
> >> included.
> >>
> >
> > AFAIK it is not present on n900...
> 
> Right, it uses twl5030 variant without the charger, charging on n900
> is provided by separate chip and for a good reason as twl's charger is
> not that good. Forcing the driver to load just ends up with it
> accessing non-existent registers over i2c.

Ok, but:

1) Why is the twl4030-bci enabled in n900's dts, then

and

2) When it is enabled, why it does not load?

(I guess there's no way to get to input voltage on n900...?)

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html