From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbbCFW4L (ORCPT ); Fri, 6 Mar 2015 17:56:11 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:35201 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbbCFW4J (ORCPT ); Fri, 6 Mar 2015 17:56:09 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Pavel Machek Subject: Re: twl4030_charger: need changes to get probed? Date: Fri, 6 Mar 2015 23:56:06 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-46-generic; KDE/4.14.2; x86_64; ; ) Cc: Grazvydas Ignotas , ivo.g.dimitrov.75@gmail.com, Samuel Ortiz , khilman@kernel.org, NeilBrown , sre@debian.org, linux-pm@vger.kernel.org, Aaro Koskinen , "Dmitry Eremin-Solenikov" , kernel list , Sebastian Reichel , GTA04 owners , sre@ring0.de, Tony Lindgren , David Woodhouse , "linux-omap@vger.kernel.org" , Lee Jones , patrikbachan@gmail.com, "linux-arm-kernel" References: <20150224043341.4243.23291.stgit@notabene.brown> <20150306224034.GA20559@amd> In-Reply-To: <20150306224034.GA20559@amd> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1632230.Lj8Be8I94Y"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201503062356.06110@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1632230.Lj8Be8I94Y Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Friday 06 March 2015 23:40:34 Pavel Machek wrote: > On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote: > > On Fri, Mar 6, 2015 at 11:57 PM, Pali Roh=C3=A1r > > wrote: > > > On Friday 06 March 2015 22:24:17 Pavel Machek wrote: > > >> Hi! > > >>=20 > > >> According to n900 dts, twl4030-bci (aka charger) should > > >> be included. > > >=20 > > > AFAIK it is not present on n900... > >=20 > > Right, it uses twl5030 variant without the charger, charging > > on n900 is provided by separate chip and for a good reason > > as twl's charger is not that good. Forcing the driver to > > load just ends up with it accessing non-existent registers > > over i2c. >=20 > Ok, but: >=20 > 1) Why is the twl4030-bci enabled in n900's dts, then >=20 maybe it is bug in n900 dts... Grazvydas, is there some runtime check if twl4030/twl5030 chip=20 has charger or not? or do we need to explicitly disable device=20 twl4030-bci in DT? > and >=20 > 2) When it is enabled, why it does not load? >=20 > (I guess there's no way to get to input voltage on n900...?) >=20 > Pavel you can read voltage only from rx51_battery.ko (TWL ADC) or=20 bq27x00_battery.ko look for Nokia_N900_RX-51_Schematics.pdf file where you can find=20 information what is connected to ADC and bq27200 chip. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1632230.Lj8Be8I94Y Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlT6MIYACgkQi/DJPQPkQ1IhHwCfftLheK7rQDlP7eUn996Srk4Y ipYAoMsN4mMCc4rPvMPlRnAZB8ZSFmim =m3Tn -----END PGP SIGNATURE----- --nextPart1632230.Lj8Be8I94Y--