From: Wolfram Sang <wsa@the-dreams.de>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "christian.ruppert@alitech.com" <christian.ruppert@alitech.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"christian.ruppert@abilis.com" <christian.ruppert@abilis.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER
Date: Sat, 7 Mar 2015 01:24:48 +0100 [thread overview]
Message-ID: <20150307002447.GE993@katana> (raw)
In-Reply-To: <1425400650.17965.53.camel@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
> > Presented like this I wonder if this merits being a dev_err at all.
> > Wouldn't dev_dbg be more adequate? This might remove the need for the
> > condition and also avoid bothering everyone if something in the platform
> > device structures or device tree is not right.
> >
> > > return irq; /* -ENXIO */
> > > }
>
> We've just had similar discussion related to DW APB UART with Andy here
> https://lkml.org/lkml/2015/3/3/412
>
> So yes probably we may safely remove error message from here completely.
So, do you want to send a V2?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-07 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:27 [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Alexey Brodkin
2015-03-03 16:28 ` Christian Ruppert
2015-03-03 16:37 ` Alexey Brodkin
2015-03-03 16:50 ` christian.ruppert
2015-03-03 17:21 ` Wolfram Sang
2015-03-03 17:46 ` Christian Ruppert
2015-03-03 19:03 ` Andy Shevchenko
2015-03-03 19:11 ` Wolfram Sang
2015-03-03 19:34 ` Andy Shevchenko
2015-03-07 0:24 ` Wolfram Sang [this message]
2015-03-09 8:29 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307002447.GE993@katana \
--to=wsa@the-dreams.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.ruppert@abilis.com \
--cc=christian.ruppert@alitech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).