From: Sebastian Reichel <sre@debian.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: NeilBrown <neilb@suse.de>,
pali.rohar@gmail.com, kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
GTA04 owners <gta04-owner@goldelico.com>,
linux-pm@vger.kernel.org
Subject: Re: twl4030_charger: need changes to get probed?
Date: Sat, 7 Mar 2015 22:01:02 +0100 [thread overview]
Message-ID: <20150307210102.GL5233@earth> (raw)
In-Reply-To: <20150306212417.GA24169@amd>
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
Hi,
On Fri, Mar 06, 2015 at 10:24:17PM +0100, Pavel Machek wrote:
> According to n900 dts, twl4030-bci (aka charger) should be
> included.
its part of twl, but not used on N900 afaik.
> (But it does not seem to do anything useful on n900. I was hoping for
> measurement of input voltage, but .. no.)
check for rx51-battery.
> Any ideas why the patch below is needed?
platform_driver_probe() does not support deferred probing.
Neil, can you take this patch into your series for the next round?
-- Sebastian
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
> index d35b83e..96bbbe9 100644
> --- a/drivers/power/twl4030_charger.c
> +++ b/drivers/power/twl4030_charger.c
> @@ -714,6 +722,7 @@ static const struct of_device_id twl_bci_of_match[] = {
> MODULE_DEVICE_TABLE(of, twl_bci_of_match);
>
> static struct platform_driver twl4030_bci_driver = {
> + .probe = twl4030_bci_probe,
> .driver = {
> .name = "twl4030_bci",
> .of_match_table = of_match_ptr(twl_bci_of_match),
> @@ -721,7 +730,7 @@ static struct platform_driver twl4030_bci_driver = {
> .remove = __exit_p(twl4030_bci_remove),
> };
>
> -module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe);
> +module_platform_driver(twl4030_bci_driver);
>
> MODULE_AUTHOR("Gražvydas Ignotas");
> MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-07 21:10 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 4:33 [PATCH 00/15] Enhance twl4030_charger functionality NeilBrown
2015-02-24 4:33 ` [PATCH 02/15] twl4030_charger: use devm_request_threaded_irq NeilBrown
2015-02-24 4:33 ` [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc NeilBrown
2015-03-07 20:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 01/15] power_supply core: support use of devres to register/unregister a power supply NeilBrown
2015-02-26 2:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 06/15] twl4030_charger: split uA calculation into a function NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 9:20 ` NeilBrown
2015-02-24 4:33 ` [PATCH 07/15] twl4030_charger: allow fine control of charger current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:47 ` NeilBrown
2015-03-04 10:24 ` Pavel Machek
2015-03-07 20:32 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 08/15] twl4030_charger: distinguish between USB current and 'AC' current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:53 ` NeilBrown
2015-02-24 4:33 ` [PATCH 05/15] twl4030_charger: trust phy to determine when USB power is available NeilBrown
2015-02-24 4:33 ` [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging NeilBrown
2015-02-25 7:24 ` Lee Jones
2015-03-05 5:48 ` NeilBrown
2015-02-24 4:33 ` [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging NeilBrown
2015-03-02 21:03 ` Pavel Machek
2015-03-04 6:15 ` NeilBrown
2015-03-04 10:19 ` Pavel Machek
2015-02-24 4:33 ` [PATCH 12/15] twl4030_charger: add software controlled linear charging mode NeilBrown
2015-03-02 21:09 ` Pavel Machek
2015-03-05 6:33 ` NeilBrown
2015-03-06 21:24 ` twl4030_charger: need changes to get probed? Pavel Machek
2015-03-06 21:57 ` Pali Rohár
2015-03-06 22:12 ` Grazvydas Ignotas
2015-03-06 22:40 ` Pavel Machek
2015-03-06 22:56 ` Pali Rohár
2015-03-07 15:56 ` Grazvydas Ignotas
2015-03-07 16:43 ` Pali Rohár
2015-04-26 10:13 ` Pavel Machek
2015-03-07 21:01 ` Sebastian Reichel [this message]
2015-03-09 0:06 ` NeilBrown
2015-03-09 11:14 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-05 6:26 ` NeilBrown
2015-03-05 8:17 ` Pavel Machek
2015-03-07 20:37 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 10/15] twl4030_charger: only draw USB current as negotiated with host NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-02-24 4:33 ` [PATCH 14/15] twl4030_charger: Increase current carefully while watching voltage NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:51 ` NeilBrown
2015-02-24 4:33 ` [PATCH 13/15] twl4030_charger: add ac/mode to match usb/mode NeilBrown
2015-03-02 21:13 ` Pavel Machek
2015-03-06 21:59 ` Grazvydas Ignotas
2015-03-22 23:13 ` NeilBrown
2015-02-24 4:33 ` [PATCH 15/15] twl4030_charger: assume a 'charger' can supply maximum current NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:45 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307210102.GL5233@earth \
--to=sre@debian.org \
--cc=aaro.koskinen@iki.fi \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gta04-owner@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neilb@suse.de \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).