linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: chien.yen@oracle.com, rds-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	roland@purestorage.com, sowmini.varadhan@oracle.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] rds: avoid potential stack overflow
Date: Mon, 09 Mar 2015 22:41:18 -0400 (EDT)	[thread overview]
Message-ID: <20150309.224118.1760532839925378471.davem@davemloft.net> (raw)
In-Reply-To: <17806664.ym3oszzFIH@wuerfel>

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 09 Mar 2015 13:06:52 +0100

> The rds_iw_add_conn function stores a large 'struct rds_sock' object
> on the stack in order to pass a pair of addresses.

As Sowmini pointed out, this function is not the top-level
guilty one, it's rds_iw_update_cm_id.

Please respin this with a corrected commit message, thanks.

      parent reply	other threads:[~2015-03-10  2:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 12:06 [PATCH] rds: avoid potential stack overflow Arnd Bergmann
2015-03-09 14:19 ` Sowmini Varadhan
2015-03-10  2:41 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309.224118.1760532839925378471.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=chien.yen@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=roland@purestorage.com \
    --cc=sowmini.varadhan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).