From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932169AbbCILYt (ORCPT ); Mon, 9 Mar 2015 07:24:49 -0400 Received: from mta-out1.inet.fi ([62.71.2.227]:32978 "EHLO jenni2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754400AbbCILYm (ORCPT ); Mon, 9 Mar 2015 07:24:42 -0400 Date: Mon, 9 Mar 2015 13:24:29 +0200 From: "Kirill A. Shutemov" To: David Rientjes Cc: Andrew Morton , Naoya Horiguchi , Davidlohr Bueso , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v2] mm, hugetlb: abort __get_user_pages if current has been oom killed Message-ID: <20150309112429.GA14936@node.dhcp.inet.fi> References: <20150309043051.GA13380@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 12:42:15AM -0700, David Rientjes wrote: > If __get_user_pages() is faulting a significant number of hugetlb pages, > usually as the result of mmap(MAP_LOCKED), it can potentially allocate a > very large amount of memory. > > If the process has been oom killed, this will cause a lot of memory to > be overcharged to its memcg since it has access to memory reserves or > could potentially deplete all system memory reserves. > > In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() > interruptible") aborted for pending SIGKILLs when faulting non-hugetlb > memory, based on the premise of commit 462e00cc7151 ("oom: stop > allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now > terminate when the process has been oom killed. > > Cc: Naoya Horiguchi > Cc: Davidlohr Bueso > Cc: "Kirill A. Shutemov" > Signed-off-by: David Rientjes Acked-by: Kirill A. Shutemo -- Kirill A. Shutemov