From: Marcelo Tosatti <mtosatti@redhat.com>
To: Joel Schopp <joel.schopp@amd.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, David Kaplan <David.Kaplan@amd.com>,
rkrcmar@redhat.com, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86: svm: make wbinvd faster
Date: Mon, 9 Mar 2015 20:28:46 -0300 [thread overview]
Message-ID: <20150309232846.GB12125@amt.cnet> (raw)
In-Reply-To: <20150228001917.15247.41063.stgit@joelvmguard2.amd.com>
On Fri, Feb 27, 2015 at 06:19:18PM -0600, Joel Schopp wrote:
> From: David Kaplan <David.Kaplan@amd.com>
> No need to re-decode WBINVD since we know what it is from the intercept.
>
> Signed-off-by: David Kaplan <David.Kaplan@amd.com>
> [extracted from larger unlrelated patch, forward ported, tested]
> Signed-off-by: Joel Schopp <joel.schopp@amd.com>
Can't you disable the intercept if need_emulate_wbinvd(vcpu) == false?
> ---
> arch/x86/kvm/svm.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index d319e0c..86ecd21 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -2776,6 +2776,14 @@ static int skinit_interception(struct vcpu_svm *svm)
> return 1;
> }
>
> +static int wbinvd_interception(struct vcpu_svm *svm)
> +{
> + kvm_emulate_wbinvd(&svm->vcpu);
> + skip_emulated_instruction(&svm->vcpu);
> + return 1;
> +}
> +
> +
> static int xsetbv_interception(struct vcpu_svm *svm)
> {
> u64 new_bv = kvm_read_edx_eax(&svm->vcpu);
> @@ -3376,7 +3384,7 @@ static int (*const svm_exit_handlers[])(struct vcpu_svm *svm) = {
> [SVM_EXIT_STGI] = stgi_interception,
> [SVM_EXIT_CLGI] = clgi_interception,
> [SVM_EXIT_SKINIT] = skinit_interception,
> - [SVM_EXIT_WBINVD] = emulate_on_interception,
> + [SVM_EXIT_WBINVD] = wbinvd_interception,
> [SVM_EXIT_MONITOR] = monitor_interception,
> [SVM_EXIT_MWAIT] = mwait_interception,
> [SVM_EXIT_XSETBV] = xsetbv_interception,
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-09 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 0:19 [PATCH] x86: svm: make wbinvd faster Joel Schopp
2015-03-02 2:29 ` Bandan Das
2015-03-02 13:59 ` Radim Krčmář
2015-03-02 15:25 ` Bandan Das
2015-03-02 16:03 ` Radim Krčmář
2015-03-02 16:58 ` Joel Schopp
2015-03-02 14:09 ` Radim Krčmář
2015-03-09 23:28 ` Marcelo Tosatti [this message]
2015-03-10 11:01 ` Radim Krčmář
2015-03-10 22:37 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309232846.GB12125@amt.cnet \
--to=mtosatti@redhat.com \
--cc=David.Kaplan@amd.com \
--cc=bp@alien8.de \
--cc=gleb@kernel.org \
--cc=joel.schopp@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).