From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbbCJDlw (ORCPT ); Mon, 9 Mar 2015 23:41:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:20458 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbbCJDlu (ORCPT ); Mon, 9 Mar 2015 23:41:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,372,1422950400"; d="scan'208";a="662856866" Date: Tue, 10 Mar 2015 11:41:39 +0800 From: Fengguang Wu To: Mark Brown Cc: Rongjun Ying , kbuild-all@01.org, Barry Song , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static Message-ID: <20150310034139.GA17221@wfg-t540p.sh.intel.com> References: <201502060130.hszyNa1F%fengguang.wu@intel.com> <20150205170352.GA49811@snb> <20150205171159.GY21293@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150205171159.GY21293@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 05, 2015 at 05:11:59PM +0000, Mark Brown wrote: > On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: > > sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? > > This file isn't in an upstream tree, should this patch have been sent > upstream (I suspect non-upstream trees may need a bit of filtering in > the scripts)? Good point! I just added some tests trying to avoid this, which should be much better, but nevertheless not complete enough to cover all cases. Please help point out inadequate cases when you come across them in future! Thanks, Fengguang