From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbbCJHmk (ORCPT ); Tue, 10 Mar 2015 03:42:40 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:46346 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbbCJHmg (ORCPT ); Tue, 10 Mar 2015 03:42:36 -0400 Date: Tue, 10 Mar 2015 13:12:26 +0530 From: Sudip Mukherjee To: Lorenzo Stoakes Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Fix sparse warning Message-ID: <20150310074226.GA12561@sudip-PC> References: <1425934628-3717-1-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425934628-3717-1-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 08:57:08PM +0000, Lorenzo Stoakes wrote: > > +#include > + apart from what Dan Carpenter has said, this is introducing one checkpatch warning, better to use #include checkpatch is also giving warning about your patch subject only one concern - if Greg first applies the patches i sent yesterday then this patch will not apply, and if this one is applied first then my series will not apply ... regards sudip > /* This is all the chips recognized by this library */ > mmio750 = addr; > devId750 = devId; > -- > 2.3.2 >