From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
David Airlie <airlied@linux.ie>,
Kumar Gala <galak@codeaurora.org>,
dianders@chromium.org, djkurtz@chromium.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
broonie@kernel.org, dri-devel@lists.freedesktop.org,
Yakir Yang <ykk@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
Mark Yao <mark.yao@rock-chips.com>
Subject: Re: [PATCH 0/3] add power-supply support to dw_hdmi
Date: Tue, 10 Mar 2015 09:58:18 +0000 [thread overview]
Message-ID: <20150310095818.GG8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1429128.MSqYm0qZ9p@phil>
On Tue, Mar 10, 2015 at 12:21:21AM +0100, Heiko Stuebner wrote:
> At least the Rockchip variant of the dw_hdmi should control its supplying
> regulators. A cursory glance at the imx manual didn't any equivalent there,
> so I'm not sure if there are similar controllable regulators present.
>
> Patch1 is only a small fix to keep {devm_}regulator_bulk_get quiet in
> the deferring case and could go directly to the regulator tree, if ok.
>
> Patch3 is the addition of the supplies to the rk3288 boards and I would
> take it into my dts branch if patch2 gets deemed acceptable.
I have a problem with this approach.
Rather than trying to shove everything into the generic part of the driver,
what we should be doing is ensuring that the generic part stays generic,
and the specific implementation details end up in the appropriate place.
As Rockchip needs these external regulators, they should be in that part
of the driver, and controlled appropriately from the encoder callbacks.
The encoder has sufficient callbacks to be able to turn on/off regulators
both before and after the bridge has been disabled/enabled.
When we see more implementations with regulators, then we can think about
moving it into the core dw_hdmi driver code.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2015-03-10 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 23:21 [PATCH 0/3] add power-supply support to dw_hdmi Heiko Stuebner
2015-03-09 23:22 ` [PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering Heiko Stuebner
2015-03-10 12:07 ` Mark Brown
2015-03-10 12:33 ` Heiko Stuebner
2015-03-09 23:22 ` [PATCH 2/3] drm/bridge: dw-hdmi: support optional supply regulators Heiko Stuebner
2015-03-10 9:16 ` Philipp Zabel
2015-03-10 9:43 ` Heiko Stuebner
2015-03-09 23:23 ` [PATCH 3/3] ARM: dts: rockchip: add hdmi analog power supplies to rk3288 boards Heiko Stuebner
2015-03-10 9:08 ` [PATCH 0/3] add power-supply support to dw_hdmi Philipp Zabel
2015-03-10 9:58 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310095818.GG8656@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).