From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Denys Vlasenko <vda.linux@googlemail.com>,
Shuah Khan <shuah.kh@samsung.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2] x86, selftests: Add sigreturn_32 selftest
Date: Tue, 10 Mar 2015 14:55:11 +0100 [thread overview]
Message-ID: <20150310135511.GA26689@gmail.com> (raw)
In-Reply-To: <CALCETrU2tcRt+AVwVN3z6cSev4g824b7gndBt+QT1ZU+nm63kQ@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Mar 9, 2015 at 9:57 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Andy Lutomirski <luto@amacapital.net> wrote:
> >
> >> On Mon, Mar 9, 2015 at 9:48 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >> >
> >> > now I get this build failure:
> >> >
> >> > make[1]: Entering directory
> >> > '/home/mingo/tip/tools/testing/selftests/x86'
> >> > gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall sigreturn.c -lrt -ldl
> >> > In file included from /usr/include/time.h:27:0,
> >> > from sigreturn.c:13:
> >> > /usr/include/features.h:374:25: fatal error: sys/cdefs.h: No such file or directory
> >> > # include <sys/cdefs.h>
> >> > ^
> >> > compilation terminated.
> >> > Makefile:18: recipe for target 'sigreturn_32' failed
> >> > make[1]: *** [sigreturn_32] Error 1
> >>
> >> It builds for me on Ubuntu.
> >>
> >> It looks like your 32-bit build setup is broken. The line that's
> >> failing to compile is:
> >>
> >> #include <time.h>
> >>
> >> Are you missing 32-bit headers? This test *can't* be run as a 64-bit binary.
> >
> > Yeah, was a relatively fresh testbox, the magic incantation to get it
> > to build there was:
> >
> > apt-get install gcc-multilib libc6-i386 libc6-dev-i386
> >
> > On Fedora it's:
> >
> > yum install glibc-devel.*i686
> >
> > Might make sense to include that in a README or so.
>
> I could rig up the makefile to give that hint.
>
> Should we just say that selftests/x86 won't work if you can't build
> 32-bit binaries, or should we try to degrade more gracefully?
I'd suggest to keep it simple: just make it easy for people to
discover how to build it properly.
Thanks,
Ingo
prev parent reply other threads:[~2015-03-10 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:36 [PATCH v2] x86, selftests: Add sigreturn_32 selftest Andy Lutomirski
2015-03-09 16:48 ` Ingo Molnar
2015-03-09 17:48 ` Andy Lutomirski
2015-03-10 4:57 ` Ingo Molnar
2015-03-10 13:17 ` Andy Lutomirski
2015-03-10 13:55 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310135511.GA26689@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=rostedt@goodmis.org \
--cc=shuah.kh@samsung.com \
--cc=vda.linux@googlemail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).