From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-usb <linux-usb@vger.kernel.org>,
Brian Hutchinson <b.hutchman@gmail.com>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] phy: Add a driver for dm816x USB PHY
Date: Wed, 11 Mar 2015 08:19:27 -0700 [thread overview]
Message-ID: <20150311151927.GV5264@atomide.com> (raw)
In-Reply-To: <550011B1.5010706@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [150311 02:58]:
> Hi Tony,
>
> On Tuesday 10 March 2015 02:21 AM, Tony Lindgren wrote:
> >Add a minimal driver for dm816x USB. Otherwise we can just use
> >the existing musb_am335x and musb_dsps on dm816x.
>
> If we can use an existing driver, I'd prefer that.
Hmm that needs rewording.. Should say that with this phy
driver musb works with existing musb_dsps usb driver on
dm816x. There is no existing driver, the closest similar
thing is the legacy drivers/usb/musb/davinci.c that has
no separate phy driver.
> >+static int dm816x_usb_phy_power_off(struct phy *x)
> >+{
> >+ struct dm816x_usb_phy *phy = phy_get_drvdata(x);
> >+
> >+ pm_runtime_put(phy->dev);
>
> phy core takes care of invoking pm_runtime_put on power_off.
> So this function shouldn't be needed at all.
OK will remove the pm_runtime calls for all of them.
...
> >+ phy->refclk = devm_clk_get(phy->dev, "refclk");
> >+ if (IS_ERR(phy->refclk))
> >+ return PTR_ERR(phy->refclk);
> >+
> >+ generic_phy = devm_phy_create(phy->dev, NULL, &ops);
> >+ if (IS_ERR(generic_phy))
> >+ return PTR_ERR(generic_phy);
>
> Just invoke pm_runtime_enable before phy_create and phy core will take care of
> invoking all pm_runtime functions at appropriate time.
OK will.
Thanks,
Tony
next prev parent reply other threads:[~2015-03-11 15:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:51 [PATCH] phy: Add a driver for dm816x USB PHY Tony Lindgren
2015-03-09 21:11 ` Bin Liu
2015-03-09 21:13 ` Felipe Balbi
2015-03-09 21:17 ` Bin Liu
2015-03-09 21:20 ` Felipe Balbi
2015-03-09 21:26 ` Tony Lindgren
2015-03-09 21:35 ` Bin Liu
2015-03-09 21:41 ` Tony Lindgren
2015-03-10 14:35 ` Bin Liu
2015-03-13 18:38 ` Matthijs van Duin
2015-03-13 19:30 ` Tony Lindgren
2015-03-14 21:04 ` Matthijs van Duin
2015-03-16 16:49 ` Tony Lindgren
2015-03-16 21:16 ` Matthijs van Duin
2015-03-17 2:19 ` Tony Lindgren
2015-03-19 11:19 ` Matthijs van Duin
2015-03-19 15:57 ` Tony Lindgren
2015-03-09 21:20 ` Tony Lindgren
2015-03-09 21:31 ` Bin Liu
2015-03-11 9:58 ` Kishon Vijay Abraham I
2015-03-11 15:19 ` Tony Lindgren [this message]
2015-03-11 11:16 ` Paul Bolle
2015-03-11 15:20 ` Tony Lindgren
2015-03-12 0:56 ` Rusty Russell
2015-03-12 20:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311151927.GV5264@atomide.com \
--to=tony@atomide.com \
--cc=b.hutchman@gmail.com \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).