From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445AbbCLL16 (ORCPT ); Thu, 12 Mar 2015 07:27:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46038 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbbCLL14 (ORCPT ); Thu, 12 Mar 2015 07:27:56 -0400 Date: Thu, 12 Mar 2015 12:27:36 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Output running time and run/enabled ratio in CSV mode Message-ID: <20150312112736.GE8369@krava.redhat.com> References: <1426083387-17006-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426083387-17006-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 07:16:27AM -0700, Andi Kleen wrote: > From: Andi Kleen > > The information how much a counter ran in perf stat can be quite > interesting for other tools to judge how trustworthy a measurement is. > > Currently it is only output in non CSV mode. > > This patches make perf stat always output the running time and the > enabled/running ratio in CSV mode. > > This adds two new fields at the end for each line. I assume that existing > tools ignore new fields at the end, so it's on by default. > > Only CSV mode is affected, no difference otherwise. > > v2: Add extra print_running function > v3: Avoid printing nan > v4: Remove some elses and add brackets. > v5: Move non CSV case into print_running Reviewed-by: Jiri Olsa thanks, jirka