From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755542AbbCMDDe (ORCPT ); Thu, 12 Mar 2015 23:03:34 -0400 Received: from smtprelay0025.hostedemail.com ([216.40.44.25]:60078 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754008AbbCMDDc (ORCPT ); Thu, 12 Mar 2015 23:03:32 -0400 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:5007:6120:6261:7514:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: nose75_75e3af5d52634 X-Filterd-Recvd-Size: 1956 Date: Thu, 12 Mar 2015 23:03:29 -0400 From: Steven Rostedt To: Mike Galbraith Cc: Sebastian Andrzej Siewior , linux-rt-users , LKML , Thomas Gleixner , John Kacur Subject: Re: [rfc patch] rt,nohz_full: fix nohz_full for PREEMPT_RT_FULL Message-ID: <20150312230329.6eb5fa98@gandalf.local.home> In-Reply-To: <1426212795.3328.21.camel@gmail.com> References: <20150216111822.GA21649@linutronix.de> <1424258514.3819.39.camel@gmail.com> <20150309134535.GA13768@linutronix.de> <1425911771.30469.8.camel@gmail.com> <1425980136.3507.17.camel@gmail.com> <1426153093.4190.2.camel@gmail.com> <20150312110911.1a93c8e8@gandalf.local.home> <1426212795.3328.21.camel@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Mar 2015 03:13:15 +0100 Mike Galbraith wrote: > > > + int softirqd = IS_ENABLED(CONFIG_PREEMPT_RT_FULL); > > > + > > > + softirqd &= current == this_cpu_ksoftirqd(); > > > > Ug, binary and logical ANDs should not be combined. Just looks nasty. > > What about: > > > > softirqd = !!(IS_ENABLED(CONFIG_PREEMPT_RT_FULL) && > > current == this_cpu_ksoftirqd()); > > My way looks prettier to me, but I seem to be the only who thinks so > (this is not the first time it got a gripe), so I'll change it ;-) I shouldn't have said it looks nasty. It actually does look pretty, in an artistic kind of way. It's just not very comprehensible. -- Steve