From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbbCMFyn (ORCPT ); Fri, 13 Mar 2015 01:54:43 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:34919 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbCMFyl (ORCPT ); Fri, 13 Mar 2015 01:54:41 -0400 Date: Fri, 13 Mar 2015 11:24:29 +0530 From: Sudip Mukherjee To: Ragavendra BN Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix Message-ID: <20150313055429.GA4979@sudip-PC> References: <20150313051436.GA10544@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313051436.GA10544@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote: > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the code give no > warnings by the checpath.pl script check. your From: is still having [user] in your email address. and you are doing too many things in a single patch. one patch should do only one type of change. > > > Signed-off-by: Ragavendra BN > this extra blank line is not necessary here. regards sudip