From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932254AbbCMQYN (ORCPT ); Fri, 13 Mar 2015 12:24:13 -0400 Received: from hofr.at ([212.69.189.236]:54677 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932168AbbCMQYL (ORCPT ); Fri, 13 Mar 2015 12:24:11 -0400 Date: Fri, 13 Mar 2015 17:24:09 +0100 From: Nicholas Mc Guire To: Kalle Valo Cc: Nicholas Mc Guire , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 2/3 RFC] ath10k: wmi: match wait_for_completion_timeout return type Message-ID: <20150313162409.GA5939@opentech.at> References: <1426175362-8640-1-git-send-email-hofrat@osadl.org> <87bnjwrhse.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bnjwrhse.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Mar 2015, Kalle Valo wrote: > Nicholas Mc Guire writes: > > > Return type of wait_for_completion_timeout is unsigned long not int. > > An appropriately named unsigned long is added and the assignments fixed up. > > Rather than returning 0 (timeout) or a more or less random remaining time > > (completion success) this return 0 or 1 which also resolves the type of the > > functions being int. > > > > Signed-off-by: Nicholas Mc Guire > > Why does patch 2 in this patchset have RFC in the title but patches 1 > and 3 not? That just makes me confused, I can't tell what you want me to > do with the patches. Normally I just drop all patches (or patchsets) > which have RFC, and that's what I'm going to do now. > > To save everyone's time, when submitting something please state clearly > what's your intention. > ok - was simply unsure about the proposed change and 1 was a trivial cleanup (which should have been sent out as a seperate patch and not part of a series - my mistake) Will fix this up and repost it. sorry for the screwup - no intent to wast anybodies time. thx! hofrat