From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbbCNGkF (ORCPT ); Sat, 14 Mar 2015 02:40:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37884 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbbCNGkD (ORCPT ); Sat, 14 Mar 2015 02:40:03 -0400 Date: Sat, 14 Mar 2015 07:39:58 +0100 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 3/5 linux-next] udf: remove else after return in __load_block_bitmap() Message-ID: <20150314063958.GC2888@quack.suse.cz> References: <1426020276-13609-1-git-send-email-fabf@skynet.be> <1426020276-13609-3-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426020276-13609-3-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10-03-15 21:44:33, Fabian Frederick wrote: > else after return is not needed. Thanks. Applied to my tree. Honza > > Signed-off-by: Fabian Frederick > --- > fs/udf/balloc.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c > index 30f4641..1cd8916 100644 > --- a/fs/udf/balloc.c > +++ b/fs/udf/balloc.c > @@ -63,15 +63,14 @@ static int __load_block_bitmap(struct super_block *sb, > block_group, nr_groups); > } > > - if (bitmap->s_block_bitmap[block_group]) { > + if (bitmap->s_block_bitmap[block_group]) > return block_group; > - } else { > - retval = read_block_bitmap(sb, bitmap, block_group, > - block_group); > - if (retval < 0) > - return retval; > - return block_group; > - } > + > + retval = read_block_bitmap(sb, bitmap, block_group, block_group); > + if (retval < 0) > + return retval; > + > + return block_group; > } > > static inline int load_block_bitmap(struct super_block *sb, > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR