From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751712AbbCNHfV (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 Mar 2015 03:35:21 -0400
Received: from hofr.at ([212.69.189.236]:34083 "EHLO mail.hofr.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750787AbbCNHfQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 Mar 2015 03:35:16 -0400
Date: Sat, 14 Mar 2015 08:35:14 +0100
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Joe Perches <joe@perches.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: match more world writable permissions
Message-ID: <20150314073514.GA28244@opentech.at>
References: <1426274602-21196-1-git-send-email-hofrat@osadl.org> <1426290223.11459.62.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426290223.11459.62.camel@perches.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 13 Mar 2015, Joe Perches wrote:

> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
> 
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
> 
> Original-patch-by: Nicholas Mc Guire <hofrat@osadl.org>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  scripts/checkpatch.pl | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6b79beb..4f07d50 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
>  	$mode_perms_search .= $entry->[0];
>  }
>  
> +$our $mode_perms_world_writable = qr{
> +	S_IWUGO		|
> +	S_IWOTH		|
> +	S_IRWXUGO	|
> +	S_IALLUGO	|
> +	0[0-7][0-7][2367]
> +}x;
> +
>  our $allowed_asm_includes = qr{(?x:
>  	irq|
>  	memory|
> @@ -5356,8 +5364,8 @@ sub process {
>  			}
>  		}
>  
> -		if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
> -		    $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
> +		if ($line =~ /debugfs_create_\w+.*\b$mode_perms_world_writable\b/ ||
> +		    $line =~ /DEVICE_ATTR.*\b$mode_perms_world_writable\b/) {
>  			WARN("EXPORTED_WORLD_WRITABLE",
>  			     "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
>  		}
> 
>
yup - thats definitely the clearner solution!

thx!
hofrat