From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755596AbbCNLtI (ORCPT ); Sat, 14 Mar 2015 07:49:08 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:34165 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbbCNLtB (ORCPT ); Sat, 14 Mar 2015 07:49:01 -0400 Date: Sat, 14 Mar 2015 12:48:45 +0100 From: Johan Hovold To: Peter Hung Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP Message-ID: <20150314114845.GC9442@localhost> References: <1424944936-7117-1-git-send-email-hpeter+linux_kernel@gmail.com> <1424944936-7117-3-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424944936-7117-3-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2015 at 06:02:08PM +0800, Peter Hung wrote: > The F81232 bulk-in is RX data + LSR channel, data format is > [LSR+Data][LSR+Data]..... , We had implemented in f81232_process_read_urb(). > > Signed-off-by: Peter Hung > static void f81232_process_read_urb(struct urb *urb) > { > struct usb_serial_port *port = urb->context; > - struct f81232_private *priv = usb_get_serial_port_data(port); > unsigned char *data = urb->transfer_buffer; > - char tty_flag = TTY_NORMAL; > - unsigned long flags; > - u8 line_status; > - int i; > - > - /* update line status */ > - spin_lock_irqsave(&priv->lock, flags); > - line_status = priv->modem_status; > - priv->modem_status &= ~UART_STATE_TRANSIENT_MASK; > - spin_unlock_irqrestore(&priv->lock, flags); > + char tty_flag; > + unsigned int i; > + u8 lsr; > > - if (!urb->actual_length) > + if ((urb->actual_length < 2) || (urb->actual_length % 2)) > return; Not parsing short data (e.g. not divisible by 2) is OK I guess. You could also just discard the last odd byte, but that's up to you. Either way, I think you should add a dev_warn here rather than just silently drop it. Johan