From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561AbbCNMJv (ORCPT ); Sat, 14 Mar 2015 08:09:51 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:35802 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbCNMJt (ORCPT ); Sat, 14 Mar 2015 08:09:49 -0400 Date: Sat, 14 Mar 2015 13:09:34 +0100 From: Johan Hovold To: Peter Hung Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V8 05/10] USB: f81232: implement MCR/MSR function Message-ID: <20150314120934.GE9442@localhost> References: <1424944936-7117-1-git-send-email-hpeter+linux_kernel@gmail.com> <1424944936-7117-6-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424944936-7117-6-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2015 at 06:02:11PM +0800, Peter Hung wrote: > This patch implement relative MCR/MSR function, such like > tiocmget()/tiocmset()/dtr_rts()/carrier_raised() > > original f81232_carrier_raised() compared with wrong value UART_DCD. > It's should compared with UART_MSR_DCD. > > Signed-off-by: Peter Hung > --- > drivers/usb/serial/f81232.c | 139 +++++++++++++++++++++++++++++++++++++------- > 1 file changed, 117 insertions(+), 22 deletions(-) > +static int f81232_set_mctrl(struct usb_serial_port *port, > + unsigned int set, unsigned int clear) > +{ > + u8 urb_value; Minor nit: could you just call this "val" as it's unrelated to any urb. Also looks good otherwise. Johan