From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbbCPCDb (ORCPT ); Sun, 15 Mar 2015 22:03:31 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53073 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbbCPCDa (ORCPT ); Sun, 15 Mar 2015 22:03:30 -0400 Date: Sun, 15 Mar 2015 22:03:27 -0400 (EDT) Message-Id: <20150315.220327.1395688557673633308.davem@davemloft.net> To: ast@plumgrid.com Cc: daniel@iogearbox.net, tgraf@suug.ch, linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 0/2] bpf: allow eBPF access skb fields From: David Miller In-Reply-To: <1426273064-4837-1-git-send-email-ast@plumgrid.com> References: <1426273064-4837-1-git-send-email-ast@plumgrid.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexei Starovoitov Date: Fri, 13 Mar 2015 11:57:41 -0700 > Hi All, > > V1->V2: > - refactored field access converter into common helper convert_skb_access() > used in both classic and extended BPF > - added missing build_bug_on for field 'len' > - added comment to uapi/linux/bpf.h as suggested by Daniel > - dropped exposing 'ifindex' field for now > > classic BPF has a way to access skb fields, whereas extended BPF didn't. > This patch introduces this ability. I've applied this series. I guess you guys can argue forever where the SKB offset validation checks should be, and if you decide to do things differently than it is done in this series just send me a followup patch. Thanks.