From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753278AbbCPK2Y (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 06:28:24 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:35955 "EHLO
	mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753062AbbCPK2V (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 06:28:21 -0400
Date: Mon, 16 Mar 2015 11:28:15 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Oleg Nesterov <oleg@redhat.com>, Dave Hansen <dave.hansen@intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Pekka Riikonen <priikone@iki.fi>, Rik van Riel <riel@redhat.com>,
        Suresh Siddha <sbsiddha@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: Re: [PATCH 4/4] x86/fpu: don't abuse drop_init_fpu() in
 flush_thread()
Message-ID: <20150316102815.GB26538@gmail.com>
References: <20150313161958.GI31998@pd.tnic>
 <20150313162654.GA26453@redhat.com>
 <20150313192717.GJ31998@pd.tnic>
 <20150314144816.GA13029@redhat.com>
 <20150315173620.GA29134@pd.tnic>
 <20150315181643.GA488@redhat.com>
 <20150315185048.GB29134@pd.tnic>
 <20150315200436.GA30079@redhat.com>
 <20150315203816.GC29134@pd.tnic>
 <20150316093537.GC22995@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150316093537.GC22995@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@suse.de> wrote:

> On Sun, Mar 15, 2015 at 09:38:16PM +0100, Borislav Petkov wrote:
> > How about we call this function fpu_reset_state() instead?
> 
> IOW, something like this. Reading the usage sites actually make much
> more sense to me now. It could be just me though...
> 
> :-)
> 
> ---
> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 16 Mar 2015 10:21:55 +0100
> Subject: [PATCH] x86/fpu: Rename drop_init_fpu() to fpu_reset_state()
> 
> Call it what it does and in accordance with the context where it is
> used: we reset the FPU state either because we were unable to restore it
> from the one saved in the task or because we simply want to reset it.

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo