From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933262AbbCPOW5 (ORCPT ); Mon, 16 Mar 2015 10:22:57 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:54387 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933230AbbCPOWp (ORCPT ); Mon, 16 Mar 2015 10:22:45 -0400 Date: Mon, 16 Mar 2015 14:22:29 +0000 From: One Thousand Gnomes To: Ameen Ali Cc: jslaby@suse.cz, tiwai@suse.de, joe@perches.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] drivers/tty/vt/vt.c : access out-of-bounds Message-ID: <20150316142229.0b2145ad@lxorguk.ukuu.org.uk> In-Reply-To: <1426337182-4790-1-git-send-email-ameenali023@gmail.com> References: <1426337182-4790-1-git-send-email-ameenali023@gmail.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Mar 2015 14:46:22 +0200 Ameen Ali wrote: > make sure that out-of-bounds never happens > > Signed-off-by : Ameen Ali > --- > drivers/tty/vt/vt.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 6e00572..cf73e92 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -1364,13 +1364,13 @@ static void csi_m(struct vc_data *vc) > i++; > if (i > vc->vc_npar) > break; It's checked in advance ^^^^^^^^^^^^^^^^^^^^^^^^^^ I guess whatever tool you used to verify it is concerned about the case of i == vc->vc_npar ? Alan