From: Ingo Molnar <mingo@kernel.org>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug
Date: Mon, 16 Mar 2015 16:01:02 +0100 [thread overview]
Message-ID: <20150316150101.GA18521@gmail.com> (raw)
In-Reply-To: <1426231647-11966-1-git-send-email-wanpeng.li@linux.intel.com>
* Wanpeng Li <wanpeng.li@linux.intel.com> wrote:
> I observe that dl task can't be migrated to other cpus during cpu hotplug,
> in addition, task may/may not be running again if cpu is added back. The
> root cause which I found is that dl task will be throtted and removed from
> dl rq after comsuming all budget, which leads to stop task can't pick it up
> from dl rq and migrate to other cpus during hotplug.
>
> The method to reproduce:
> schedtool -E -t 50000:100000 -e ./test
> Actually test is just a simple for loop. Then observe which cpu the test
> task is on.
> echo 0 > /sys/devices/system/cpu/cpuN/online
>
> This patch adds the dl task migration during cpu hotplug by finding a most
> suitable later deadline rq after dl timer fire if current rq is offline,
> if fail to find a suitable later deadline rq then fallback to any eligible
> online cpu in order that the deadline task will come back to us, and the
> push/pull mechanism should then move it around properly.
>
> Suggested-and-acked-by: Juri Lelli <juri.lelli@arm.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
> ---
> kernel/sched/deadline.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5cb5c9c..db457b9 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -492,6 +492,7 @@ static int start_dl_timer(struct sched_dl_entity *dl_se, bool boosted)
> return hrtimer_active(&dl_se->dl_timer);
> }
>
> +static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
> /*
> * This is the bandwidth enforcement timer callback. If here, we know
> * a task is not on its dl_rq, since the fact that the timer was running
> @@ -537,6 +538,59 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
> update_rq_clock(rq);
>
> /*
> + * So if we find that the rq the task was on is no longer
> + * available, we need to select a new rq.
> + */
> + if (unlikely(!rq->online)) {
> + struct rq *later_rq = NULL;
> + bool fallback = false;
> +
> + later_rq = find_lock_later_rq(p, rq);
> +
> + if (!later_rq) {
> + int cpu;
> +
> + /*
> + * If cannot preempt any rq, fallback to pick any
> + * online cpu.
s/If cannot/If we cannot
s/fallback/fall back
> + */
> + fallback = true;
> + cpu = cpumask_any_and(cpu_active_mask,
> + tsk_cpus_allowed(p));
shouldn't be on separate lines - but this is also a sign that the guts
of this new code should be in a helper function, not inside several
layers of branches.
> + if (cpu >= nr_cpu_ids) {
> + if (dl_bandwidth_enabled()) {
> + /*
> + * Fail to find any suitable cpu.
> + * The task will never come back!
> + */
> + WARN_ON(1);
Can this condition happen to users with a non-buggy kernel?
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-16 15:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 7:27 [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug Wanpeng Li
2015-03-16 12:09 ` Wanpeng Li
2015-03-16 15:01 ` Ingo Molnar [this message]
2015-03-16 23:01 ` Wanpeng Li
2015-03-17 8:06 ` Ingo Molnar
2015-03-17 7:53 ` Wanpeng Li
2015-03-17 8:13 ` Ingo Molnar
2015-03-17 7:59 ` Wanpeng Li
2015-03-23 7:25 ` Ingo Molnar
2015-03-23 8:55 ` Peter Zijlstra
2015-03-24 9:27 ` Juri Lelli
2015-03-24 9:13 ` Wanpeng Li
2015-03-24 10:00 ` Juri Lelli
2015-03-24 9:43 ` Wanpeng Li
2015-03-30 9:12 ` Peter Zijlstra
2015-03-31 8:55 ` Juri Lelli
2015-03-24 9:50 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316150101.GA18521@gmail.com \
--to=mingo@kernel.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).