From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935513AbbCPQZY (ORCPT ); Mon, 16 Mar 2015 12:25:24 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39068 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933294AbbCPQZW (ORCPT ); Mon, 16 Mar 2015 12:25:22 -0400 Date: Mon, 16 Mar 2015 11:25:18 -0500 From: rkuo To: Alex Dowad Cc: linux-kernel@vger.kernel.org, "open list:QUALCOMM HEXAGON..." Subject: Re: [PATCH 12/32] hexagon: copy_thread(): rename 'arg' argument to 'kthread_arg' Message-ID: <20150316162518.GA15501@codeaurora.org> References: <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com> <1426270496-26362-2-git-send-email-alexinbeijing@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426270496-26362-2-git-send-email-alexinbeijing@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 08:14:35PM +0200, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a new > kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency > with do_fork() and other arch-specific implementations of copy_thread()). > > Signed-off-by: Alex Dowad > --- > arch/hexagon/kernel/process.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/hexagon/kernel/process.c b/arch/hexagon/kernel/process.c > index 0a0dd5c..6f27358 100644 > --- a/arch/hexagon/kernel/process.c > +++ b/arch/hexagon/kernel/process.c > @@ -71,7 +71,7 @@ unsigned long thread_saved_pc(struct task_struct *tsk) > * Copy architecture-specific thread state > */ > int copy_thread(unsigned long clone_flags, unsigned long usp, > - unsigned long arg, struct task_struct *p) > + unsigned long kthread_arg, struct task_struct *p) > { > struct thread_info *ti = task_thread_info(p); > struct hexagon_switch_stack *ss; > @@ -94,10 +94,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, > ss->lr = (unsigned long)ret_from_fork; > p->thread.switch_sp = ss; > if (unlikely(p->flags & PF_KTHREAD)) { > + /* kernel thread */ > memset(childregs, 0, sizeof(struct pt_regs)); > /* r24 <- fn, r25 <- arg */ > ss->r24 = usp; > - ss->r25 = arg; > + ss->r25 = kthread_arg; > pt_set_kmode(childregs); > return 0; > } > -- > 2.0.0.GIT > Acked-by: Richard Kuo -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project