From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964908AbbCPQyn (ORCPT ); Mon, 16 Mar 2015 12:54:43 -0400 Received: from muru.com ([72.249.23.125]:37653 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933202AbbCPQym (ORCPT ); Mon, 16 Mar 2015 12:54:42 -0400 Date: Mon, 16 Mar 2015 09:49:51 -0700 From: Tony Lindgren To: Matthijs van Duin Cc: Bin Liu , Felipe Balbi , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, "linux-omap@vger.kernel.org" , linux-usb , Brian Hutchinson Subject: Re: [PATCH] phy: Add a driver for dm816x USB PHY Message-ID: <20150316164951.GR5264@atomide.com> References: <20150309211306.GC22341@saruman.tx.rr.com> <20150309212014.GE22341@saruman.tx.rr.com> <20150309212622.GJ5264@atomide.com> <20150309214129.GK5264@atomide.com> <20150313193058.GN5264@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matthijs van Duin [150314 14:04]: > On 13 March 2015 at 20:30, Tony Lindgren wrote: > > Hmm OK have to check that. It could also be that dm816x documentation > > is copy-paste from da850 or am3517 and the PHY got changed in the > > hardware as the registers don't match the documentation. Only the > > dm816x errata has right documentation for the USB PHY. > > Hmm? While I see plenty of usb errata (mostly DMA bugs), I don't see > anything about registers being different. Sorry it seems to be the partially updated TRM instead, it's the sprs614e.pdf instead. That has the USBPHY_CTRL registers right. No mention of Synopsys in sprs614e.pdf though so who knows. It seems something got swapped compared to the TRM as the USB_CTRL registers totally changed. I'll just add a comments you mentioned earlier about it probably being Synopsys phy. > I do see something curious: advisory 70, the only PHY-related erratum > I see, is also present in the DM814x errata and even in AM335x r1.0. > This strongly suggests the PHYs must at least be closely related... Hmm interesting. But dm814x has again different USB_CTRL registers, seems to be wired up like am335x. Also there's no USBPHY_CTRL registers on dm814x or am335x. Chances are that dm814x is wired up the same way as am335x. > The dm816x TRM makes three separate mentions of the synopsys usb phy > though, while I found no other TRMs that mention it, so if it's a > copy-paste error (which certainly would not be exceptional) I don't > know where from. Yes I checked am3517 trm, and that too mentions Synopsys once, but has different registers. And also checked the l-138/da850 TRM, and that does not have USB_CTRL and USBPHY_CTRL registers either.. Looks like the copy paste errors come from tms320dm6446.pdf that has the USB_CTRL and USBPHY_CTRL registers, but then no mention of Synopsys. > I suppose it's still possible TI acquired a sufficiently permissive > license for the synopsys phy to fork it and call it a "TI PHY" as they > do in the AM335x docs. (No mention of its origin is made in the DM814x > docs.) > > BTW, da850? Is that yet another instance of Primus? (i.e. > omap-L1xx/c674x/am1xxx with odd final digit, also da830/da828) Yes it's the arm926 based series, l-138 is da850 I believe. Regards, Tony