From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: match more world writable permissions
Date: Tue, 17 Mar 2015 16:17:18 -0700 [thread overview]
Message-ID: <20150317161718.48428cd7a997cfa3ec4be90e@linux-foundation.org> (raw)
In-Reply-To: <1426290223.11459.62.camel@perches.com>
On Fri, 13 Mar 2015 16:43:43 -0700 Joe Perches <joe@perches.com> wrote:
> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
>
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
>
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
> $mode_perms_search .= $entry->[0];
> }
>
> +$our $mode_perms_world_writable = qr{
> + S_IWUGO |
> + S_IWOTH |
> + S_IRWXUGO |
> + S_IALLUGO |
> + 0[0-7][0-7][2367]
> +}x;
> +
Scalar found where operator expected at scripts/checkpatch.pl line 446, near "$our $mode_perms_world_writable"
(Missing operator before $mode_perms_world_writable?)
Global symbol "$our" requires explicit package name at scripts/checkpatch.pl line 446.
syntax error at scripts/checkpatch.pl line 446, near "$our $mode_perms_world_writable "
Global symbol "$mode_perms_world_writable" requires explicit package name at scripts/checkpatch.pl line 446.
BEGIN not safe after errors--compilation aborted at scripts/checkpatch.pl line 663.
akpm3:/usr/src/25> perl --version
This is perl 5, version 18, subversion 2 (v5.18.2) built for x86_64-linux-gnu-thread-multi
This?
--- a/scripts/checkpatch.pl~checkpatch-match-more-world-writable-permissions-fix
+++ a/scripts/checkpatch.pl
@@ -443,7 +443,7 @@ foreach my $entry (@mode_permission_func
$mode_perms_search .= $entry->[0];
}
-$our $mode_perms_world_writable = qr{
+our $mode_perms_world_writable = qr{
S_IWUGO |
S_IWOTH |
S_IRWXUGO |
_
next prev parent reply other threads:[~2015-03-17 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 19:23 [PATCH] checkpatch: catch all world writable debugfs_create_file Nicholas Mc Guire
2015-03-13 20:16 ` Joe Perches
2015-03-13 20:42 ` Joe Perches
2015-03-13 23:43 ` [PATCH] checkpatch: match more world writable permissions Joe Perches
2015-03-14 7:35 ` Nicholas Mc Guire
2015-03-14 14:32 ` Guenter Roeck
2015-03-14 15:42 ` Joe Perches
2015-03-17 23:17 ` Andrew Morton [this message]
2015-03-18 5:56 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317161718.48428cd7a997cfa3ec4be90e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=hofrat@osadl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).