From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653AbbCSOql (ORCPT ); Thu, 19 Mar 2015 10:46:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50293 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbbCSOqj (ORCPT ); Thu, 19 Mar 2015 10:46:39 -0400 Date: Thu, 19 Mar 2015 10:46:27 -0400 From: Benjamin Tissoires To: Yves-Alexis Perez Cc: Dmitry Torokhov , Andrew Duggan , Hans de Goede , Peter Hutterer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time! Message-ID: <20150319144627.GA18134@mail.corp.redhat.com> References: <1423253075-23469-1-git-send-email-benjamin.tissoires@redhat.com> <20150319142450.GA1641@balvenie> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150319142450.GA1641@balvenie> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 19 2015 or thereabouts, Yves-Alexis Perez wrote: > On Fri, Feb 06, 2015 at 03:04:28PM -0500, Benjamin Tissoires wrote: > > Hi, > > > > This is the second episode of the Lenovo 2015 party :) > > > > Thanks to Andrew, we now have an idea within the driver of what are the extra > > buttons aimed for, and the patch series looks cleaner. > > Many thanks for your help. > > > > I marked only patches 1/7, 2/7 and 3/7 as stable because they are really > > stable fixes. Without the rest of the series, user-space can cope with the > > kernel result, and so there is IMO no need to backport too many patches in > > stable. I bet distributions will cherry-pick the rest of the series however. > > > Hi, > > I recently bought a ThinkPad X250 [1]. I'm running Debian sid with the > 4.0-rc4 kernel right now. > > I don't use the touchpad at all, but rather the trackpoint, so I > disabled the touchpad in the BIOS. Following some advice, I setup the > input system using psmouse.proto=imps with a custom Xorg.conf.d config > file for the “touchpad” (the Trackpoint device disappears when using > IMPS). It works fine with xf86-input-evdev, and the psmouse module > correctly respects the BIOS setting (the touchpad itself is disabled). > > Then I was made aware of that patch set and of the xf86-input-synaptics > patches [2]. > > I tried the patchset at [3], disabling the psmouse.proto=imps, but I > don't yet installed xf86-input-synaptics. Here are the results: > > - the trackpoint device reappears > - the hardware buttons seem to work, and are assigned the the trackpoint > device (and can configured using the standard trackpoint config file) > - the touchpad is enabled, so it looks like the BIOS setting is not > respected > > So I have two questions/remarks about this: > > - if I don't use the touchpad, do I need xf86-input-synaptics at all? Wether you use it or not, with the current kernel patch set, there will be no modifications to do in xf86-input-synaptics. Legacy versions will work just fine and the trackstick/touchpads are seen like they were in the past (lik ein the thinkpads t410 .. t430). So I would advice to just revert to whatever Xorg / xf86-input-synaptics / configuration you had from your distribution, apply the patches (or wait for 4.0-rc5), and you are done. > - how can I have the BIOS setting respected by the psmouse/synaptics > kernel module (like when using psmouse) I was confused at first so I double checked. If you use the psmouse.proto=imps boot parameter, then the bios setting is respected. If the trackpad is enabled, it is barely usable, but that's what you get :) > > Thanks for your patchset anyway, and regards, Thanks for your testings. Cheers, Benjamin > > [1] http://www.corsac.net/X250 > [2] http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/ > [3] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/log/ > -- > Yves-Alexis