From: Bjorn Helgaas <bhelgaas@google.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux@arm.linux.org.uk, linux-kernel@codethink.co.uk,
Linux ARM Kernel list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PCI List <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] ARM: add PCI hotplug support
Date: Fri, 20 Mar 2015 18:22:23 -0500 [thread overview]
Message-ID: <20150320232223.GP26935@google.com> (raw)
In-Reply-To: <1426594952-1456-1-git-send-email-ben.dooks@codethink.co.uk>
On Tue, Mar 17, 2015 at 12:22:32PM +0000, Ben Dooks wrote:
> Hotplug on PCIe should work with ARM, however the necessary
> PCIe hotplug is not availale as the menu items for PCI hotplug
"available"
> have not been included.
>
> Add the include of PCI hotplug support to the ARM main Kconfig
> so that it can be selected.
>
> The only issue that was found during this is that the PCI code
> did not assign interrupts properly to newly probed devices. This
> will need to be fixed for any interrupt capable devices.
Yep, this is a known PCI problem, at least if you're referring to
the fact that pci_fixup_irqs() only happens for devices present at
boot-time. I would love for somebody to fix that generically.
I would also like to squash together the PCI, PCIe, and PCI hotplug Kconfig
options so arches would only have to include drivers/pci/Kconfig.
> This has been tested on a Marvell 88F6281 with a TI XIO3130
> PCIe bridge (with hotplug enabled) and fixes for IRQ assignment
> added.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
I assume this will be handled via an ARM tree, but if you want it:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> --
> CC: Linux ARM Kernel list <linux-arm-kernel@lists.infradead.org>
> CC: Russell King <linux@arm.linux.org.uk>
> CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Linux PCI List <linux-pci@vger.kernel.org>
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 9f1f09a..4574ab4 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1302,6 +1302,7 @@ config PCI_HOST_ITE8152
> select DMABOUNCE
>
> source "drivers/pci/Kconfig"
> +source "drivers/pci/hotplug/Kconfig"
> source "drivers/pci/pcie/Kconfig"
>
> source "drivers/pcmcia/Kconfig"
> --
> 2.1.4
>
prev parent reply other threads:[~2015-03-20 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 12:22 [PATCH] ARM: add PCI hotplug support Ben Dooks
2015-03-20 23:22 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320232223.GP26935@google.com \
--to=bhelgaas@google.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).