From: josh@joshtriplett.org
To: David Drysdale <drysdale@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>,
Oleg Nesterov <oleg@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>, Rik van Riel <riel@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Thiago Macieira <thiago.macieira@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
X86 ML <x86@kernel.org>
Subject: Re: [PATCH v2 3/7] Introduce a new clone4 syscall with more flag bits and extensible arguments
Date: Mon, 23 Mar 2015 08:05:00 -0700 [thread overview]
Message-ID: <20150323150500.GB31561@cloud> (raw)
In-Reply-To: <CAHse=S_0G028D2f1vO=1EBO-TM1ZyJZT3-VE4O3a9dS-VcdKzg@mail.gmail.com>
On Mon, Mar 23, 2015 at 02:11:45PM +0000, David Drysdale wrote:
> On Sun, Mar 15, 2015 at 7:59 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> > diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
> > index 0286735..ba28306 100644
> > --- a/arch/x86/ia32/ia32entry.S
> > +++ b/arch/x86/ia32/ia32entry.S
> > @@ -483,6 +483,7 @@ GLOBAL(\label)
> > PTREGSCALL stub32_execveat, compat_sys_execveat
> > PTREGSCALL stub32_fork, sys_fork
> > PTREGSCALL stub32_vfork, sys_vfork
> > + PTREGSCALL stub32_clone4, compat_sys_clone4
> >
> > ALIGN
> > GLOBAL(stub32_clone)
> > diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> > index 1d74d16..ead143f 100644
> > --- a/arch/x86/kernel/entry_64.S
> > +++ b/arch/x86/kernel/entry_64.S
> > @@ -520,6 +520,7 @@ END(\label)
> > FORK_LIKE clone
> > FORK_LIKE fork
> > FORK_LIKE vfork
> > + FORK_LIKE clone4
> > FIXED_FRAME stub_iopl, sys_iopl
> >
> > ENTRY(stub_execve)
> > diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
> > index b3560ec..56fcc90 100644
> > --- a/arch/x86/syscalls/syscall_32.tbl
> > +++ b/arch/x86/syscalls/syscall_32.tbl
> > @@ -365,3 +365,4 @@
> > 356 i386 memfd_create sys_memfd_create
> > 357 i386 bpf sys_bpf
> > 358 i386 execveat sys_execveat stub32_execveat
> > +359 i386 clone4 sys_clone4 stub32_clone4
> > diff --git a/arch/x86/syscalls/syscall_64.tbl b/arch/x86/syscalls/syscall_64.tbl
> > index 8d656fb..af15b0f 100644
> > --- a/arch/x86/syscalls/syscall_64.tbl
> > +++ b/arch/x86/syscalls/syscall_64.tbl
> > @@ -329,6 +329,7 @@
> > 320 common kexec_file_load sys_kexec_file_load
> > 321 common bpf sys_bpf
> > 322 64 execveat stub_execveat
> > +323 64 clone4 stub_clone4
> >
> > #
> > # x32-specific system call numbers start at 512 to avoid cache impact
> > @@ -368,3 +369,4 @@
> > 543 x32 io_setup compat_sys_io_setup
> > 544 x32 io_submit compat_sys_io_submit
> > 545 x32 execveat stub_x32_execveat
> > +546 x32 clone4 stub32_clone4
>
> Doesn't this need an x32 specific wrapper (to ensure the full
> set of registers are saved)?
I'm not an x32 expert; I don't know how x32 interacts with pt_regs and
compat syscalls. Could an x32 expert weigh in, please?
- Josh Triplett
next prev parent reply other threads:[~2015-03-23 15:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 7:59 [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor Josh Triplett
2015-03-15 7:59 ` [PATCH v2 1/7] clone: Support passing tls argument via C rather than pt_regs magic Josh Triplett
2015-03-15 7:59 ` [PATCH v2 2/7] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit Josh Triplett
2015-03-15 7:59 ` [PATCH v2 3/7] Introduce a new clone4 syscall with more flag bits and extensible arguments Josh Triplett
2015-03-23 14:11 ` David Drysdale
2015-03-23 15:05 ` josh [this message]
2015-03-31 14:41 ` David Drysdale
2015-03-15 7:59 ` [PATCH v2 4/7] kernel/fork.c: Pass arguments to _do_fork and copy_process using clone4_args Josh Triplett
2015-03-15 8:00 ` [PATCH v2 5/7] clone4: Add a CLONE_AUTOREAP flag to automatically reap the child process Josh Triplett
2015-03-15 14:52 ` Oleg Nesterov
2015-03-15 17:18 ` Josh Triplett
2015-03-15 19:55 ` Oleg Nesterov
2015-03-15 23:34 ` Josh Triplett
2015-03-20 18:14 ` Oleg Nesterov
2015-03-20 18:46 ` Thiago Macieira
2015-03-20 19:09 ` Oleg Nesterov
2015-03-20 21:10 ` josh
2015-03-15 8:00 ` [PATCH v2 6/7] signal: Factor out a helper function to process task_struct exit_code Josh Triplett
2015-03-15 8:00 ` [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd Josh Triplett
2015-03-23 17:38 ` David Drysdale
2015-03-25 14:53 ` Josh Triplett
2015-04-06 8:30 ` Sergey Senozhatsky
2015-04-06 9:31 ` Josh Triplett
2015-03-15 8:00 ` [PATCH v2 man-pages] clone4.2: New manpage documenting clone4(2) Josh Triplett
2015-03-15 8:04 ` [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor Josh Triplett
2015-03-16 21:44 ` Kees Cook
2015-03-16 22:14 ` Thiago Macieira
2015-03-16 22:36 ` Kees Cook
2015-03-16 22:50 ` Thiago Macieira
2015-03-16 23:26 ` Kees Cook
2015-03-16 23:35 ` josh
2015-03-16 23:29 ` josh
2015-03-17 0:49 ` Thiago Macieira
2015-03-23 14:12 ` David Drysdale
2015-03-23 15:03 ` josh
2015-03-16 23:25 ` josh
2015-03-31 20:08 ` Jonathan Corbet
2015-03-31 22:02 ` josh
2015-04-01 7:24 ` Jonathan Corbet
2015-04-09 2:19 ` Josh Triplett
2015-05-29 7:43 ` Florian Weimer
2015-05-29 20:27 ` Thiago Macieira
2015-06-15 10:06 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323150500.GB31561@cloud \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=drysdale@google.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=thiago.macieira@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).