From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbbCWQcp (ORCPT ); Mon, 23 Mar 2015 12:32:45 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32807 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbbCWQck (ORCPT ); Mon, 23 Mar 2015 12:32:40 -0400 Date: Mon, 23 Mar 2015 19:32:39 +0300 From: Dan Carpenter To: Silvan Jegen Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH V3] [media] mantis: fix error handling Message-ID: <20150323163239.GT16501@mwanda> References: <20150322224831.GF16501@mwanda> <1427127953-24716-1-git-send-email-s.jegen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427127953-24716-1-git-send-email-s.jegen@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 05:25:53PM +0100, Silvan Jegen wrote: > Remove dead code, make goto label names more expressive and add a label > in order to call mantis_dvb_exit if mantis_uart_init fails. > > Also make sure that mantis_pci_exit is called if we fail the > mantis_stream_control call and that we call mantis_i2c_exit if > mantis_get_mac fails. > > Signed-off-by: Silvan Jegen Looks great. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter