From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752558AbbCXN4X (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 09:56:23 -0400
Received: from casper.infradead.org ([85.118.1.10]:35618 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751917AbbCXN4W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 09:56:22 -0400
Date: Tue, 24 Mar 2015 14:56:13 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: mingo@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        yuyang.du@intel.com, preeti@linux.vnet.ibm.com, mturquette@linaro.org,
        nico@linaro.org, rjw@rjwysocki.net, juri.lelli@arm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [RFCv3 PATCH 38/48] sched: Infrastructure to query if load
 balancing is energy-aware
Message-ID: <20150324135613.GR23123@twins.programming.kicks-ass.net>
References: <1423074685-6336-1-git-send-email-morten.rasmussen@arm.com>
 <1423074685-6336-39-git-send-email-morten.rasmussen@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423074685-6336-39-git-send-email-morten.rasmussen@arm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 04, 2015 at 06:31:15PM +0000, Morten Rasmussen wrote:
> From: Dietmar Eggemann <dietmar.eggemann@arm.com>
> 
> Energy-aware load balancing should only happen if the ENERGY_AWARE feature
> is turned on and the sched domain on which the load balancing is performed
> on contains energy data.
> There is also a need during a load balance action to be able to query if we
> should continue to load balance energy-aware or if we reached the tipping
> point which forces us to fall back to the conventional load balancing
> functionality.

> @@ -7348,6 +7349,7 @@ static int load_balance(int this_cpu, struct rq *this_rq,
>  		.cpus		= cpus,
>  		.fbq_type	= all,
>  		.tasks		= LIST_HEAD_INIT(env.tasks),
> +		.use_ea		= (energy_aware() && sd->groups->sge) ? true : false,

fwiw, no tipping point in that logic.