From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbbCXQWF (ORCPT ); Tue, 24 Mar 2015 12:22:05 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59156 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754913AbbCXQWB (ORCPT ); Tue, 24 Mar 2015 12:22:01 -0400 Date: Tue, 24 Mar 2015 09:22:27 -0700 From: Mark Brown To: Markus Pargmann Cc: Liam Girdwood , Wolfram Sang , kernel@pengutronix.de, linux-kernel@vger.kernel.org Message-ID: <20150324162226.GG17265@sirena.org.uk> References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xjyYRNSh/RebjC6o" Content-Disposition: inline In-Reply-To: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> X-Cookie: A good memory does not equal pale ink. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.104.145.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: max8660: Remove boot_on handling X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xjyYRNSh/RebjC6o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 24, 2015 at 01:08:02PM +0100, Markus Pargmann wrote: > boot_on is handled by the regulator core. It will call enable() on the > regulators that are specified to be boot_on. So we don't require any > additional handling in this driver > switch (pdata->subdevs[i].id) { > case MAX8660_V3: > - if (boot_on) > - max8660->shadow_regs[MAX8660_OVER1] |= 1; > - break; > - So, this is updating the register default value rather than writing to the device. That suggests that the purpose is to either avoid needless write outs to the device or something, or at the very least it's not a completely direct reimplementation of the core functionality. It is certainly underdocumented at the minute (and the driver probably wants to be converted to regmap) but this makes me a bit cautious about obvious cleanups missing something. --xjyYRNSh/RebjC6o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVEY9CAAoJECTWi3JdVIfQpxgH/0o5Hq3ZGIGlDpCc5e4GIO5v c4KFy5+5C4qeskzwZUbqptxXNqfBvSrz9CI1yWH9HvOZ6SyEKmPeMJoiuVRDHx2T GCFcz99OBPPUOOf3r5TfFTKf+gCY2EKOlW1/RQVTWAwtmfr64X1PjL1BrSTg+ONV CCFQCuxJMgIx+aGldp56SrV9PWVuJPYcMcbJBrKmy2afE1tXwwLfytV+ACFwTuUN fwcE3nLzRZAg9JTsNiEqipBjPmF0A+5lnykcG8yuhDRK2gRQE17lXxgRcTXdcYlX Lpur+OSV4WDnPCWX/KzmiPQmvNg20tKzxdYJl56nnKZBneWG/KY1WHowQ9p0cxE= =/YjC -----END PGP SIGNATURE----- --xjyYRNSh/RebjC6o--