From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755359AbbCXQgc (ORCPT ); Tue, 24 Mar 2015 12:36:32 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:55746 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116AbbCXQg2 (ORCPT ); Tue, 24 Mar 2015 12:36:28 -0400 Date: Tue, 24 Mar 2015 17:36:24 +0100 From: Markus Pargmann To: Wolfram Sang Cc: Mark Brown , Liam Girdwood , kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: max8660: Add error message for missing regulator data Message-ID: <20150324163624.GK28604@pengutronix.de> References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> <1427198883-6577-2-git-send-email-mpa@pengutronix.de> <20150324123809.GA8766@katana> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="08ATZu8fEq0x2T3M" Content-Disposition: inline In-Reply-To: <20150324123809.GA8766@katana> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:33:39 up 62 days, 6:40, 163 users, load average: 6.19, 2.92, 1.89 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --08ATZu8fEq0x2T3M Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Wolfram, On Tue, Mar 24, 2015 at 01:38:09PM +0100, Wolfram Sang wrote: >=20 > > for (i =3D 0; i < pdata->num_subdevs; i++) { > > - if (!pdata->subdevs[i].platform_data) > > + if (!pdata->subdevs[i].platform_data) { > > + dev_err(dev, "No data for %d regulator\n", i); > > return -EINVAL; > > + } >=20 > I'd rather save the string and go for -ENOENT instead. But I don't mind > much... I think -ENOENT doesn't describe it enough. For example if pdata is parsed from DT, this may as well be a missing regulator node in the devicetree. Best Regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --08ATZu8fEq0x2T3M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEZKIAAoJEEpcgKtcEGQQXMQQAJXYnxRTDsizzlU9qiGAuSE2 ppkJuakUCGwqe67gXzEWI/Mfj+3ue/s0ChZzC4hTZd7io97q/vqYB76dl6h4RNbF K10wBVF88X5mB1x/BEwjFmsnz2NseoGdQht9SFVKyQNJJiDNbghM9UF7Sjbd6SBv Q20QH93l9pBswEUB6YoAfraCjAxf86y1CtRgLR3UXZ2IiKDCXUohcM7YKYZwsK6X hPApAbLh8b/P5Aig3UJFacpYOBpk6kC/ypbFHhclMcfQf8bvA2YlRFKMEnwYep/3 fPv+NyYruMU//7kjQpNgYKnmlBf4HMo4aO0pbTjgETTamK1m64ezTdzhyWpxMRwl mVrVkFlY77LEJAmx/efgNPYRS3WG0vQ1EIhoKaE+JOizhN/Y6r58/vfgwLlTeEwQ 5BDz2PCaQ6gL79raW+2qM94Dzvz6Kxz2L9EW3qipB6axKlOkBILzpNYa2k3ntGjD C1ZnfdUK5X+mu3UdXCL9aK9FISJSXcN2L6S+azA6FqBVdvQUvYo8rosqX+qMNtL0 56fOoDlTk4h6l+VtjwkKkMNv4GgcdDhspZ0LiwCDe0C5OhEW+ijLcdimp+uaetGk +W4yjuUFdOpJl9EhCsC9wkIQnfRTzRQNa6GU1KkV4S1PW/gMmBjZuiQ40rI4hbB1 XgTxl/WXAZRia2hIU4Rr =o19B -----END PGP SIGNATURE----- --08ATZu8fEq0x2T3M--