Re: [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer

From: Borislav Petkov <bp@alien8.de>
To: Rik van Riel <riel@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Dave Hansen <dave.hansen@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Suresh Siddha <sbsiddha@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer
Date: Wed, 25 Mar 2015 10:08:24 +0100	[thread overview]
Message-ID: <20150325090824.GB3291@pd.tnic> (raw)
In-Reply-To: <551208F8.1090806@redhat.com>

On Tue, Mar 24, 2015 at 09:01:44PM -0400, Rik van Riel wrote:
> Indeed, __save_init_fpu (yeah, terrible name) will save
> the in-register state to memory for you, so you can
> inspect it.
> 
> Is there any reason not to rename __save_init_fpu to
> save_fpu_state, or just save_fpu?

That whole place there needs more rubbing.

So the way I see it, the "init" thing also says that the FPU is intact.

__save_fpu() does *SAVE too but it misses the FNSAVE fallback for old
machines. Why TF is that so?

It also doesn't do FNCLEX and IMHO the clearing of exceptions is what
the "init" aspect in the name tries to imply.

I think we should simply merge those into a main one called

save_fpu_state() (what Rik suggests)

which does all that __save_init_fpu() does currently and a low-level
helper __save_fpu() which does only the *SAVE saving of context work.

Meh, not ecstatic about it either but it is the cleanup worth and maybe
later more stuff will collapse during further cleaning...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--