From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbbCYPZB (ORCPT ); Wed, 25 Mar 2015 11:25:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44029 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbbCYPY7 (ORCPT ); Wed, 25 Mar 2015 11:24:59 -0400 Date: Wed, 25 Mar 2015 16:24:53 +0100 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, Dave Airlie , Dave Airlie , David Airlie , Rusty Russell , open list , "open list:DRM DRIVERS" , "open list:VIRTIO CORE, NET..." , "open list:ABI/API" Subject: Re: [PATCH] Add virtio gpu driver. Message-ID: <20150325162246-mutt-send-email-mst@redhat.com> References: <1427213239-8775-1-git-send-email-kraxel@redhat.com> <20150324171255-mutt-send-email-mst@redhat.com> <1427295121.23304.5.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427295121.23304.5.camel@nilsson.home.kraxel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 03:52:01PM +0100, Gerd Hoffmann wrote: > Hi, > > > > diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c > > > index e894eb2..a3167fa 100644 > > > --- a/drivers/virtio/virtio_pci_common.c > > > +++ b/drivers/virtio/virtio_pci_common.c > > > @@ -510,7 +510,7 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, > > > goto err_enable_device; > > > > > > rc = pci_request_regions(pci_dev, "virtio-pci"); > > > - if (rc) > > > + if (rc && ((pci_dev->class >> 8) != PCI_CLASS_DISPLAY_VGA)) > > > goto err_request_regions; > > > > > > if (force_legacy) { > > > > This is probably what you described as "the only concern? > > Ahem, no, forgot that one, What does the concern refer to then? > but it is related. With vesafb using and > registering the vga compat framebuffer bar pci_request_regions will not > succeed. > > vesafb will be unregistered later on (this is what I was refering to) by > the virtio-gpu driver. > > > If we only need to request specific > > regions, I think we should do exactly that, requesting only parts of > > regions that are covered by the virtio capabilities. > > That should work too. > > cheers, > Gerd BTW can we teach virtio-gpu to look for framebuffer using virtio pci caps? Or are there limitations such as only using IO port BARs, or compatibility with BIOS code etc that limit us to specific BARs anyway? -- MST