From: Dmitry Torokhov <dtor@google.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, Anatol Pomazau <anatol@google.com>,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>
Subject: Re: [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver
Date: Wed, 25 Mar 2015 15:42:53 -0700 [thread overview]
Message-ID: <20150325224253.GA16950@dtor-ws> (raw)
In-Reply-To: <551336A2.1050704@ti.com>
Hi Kishon,
On Thu, Mar 26, 2015 at 03:58:50AM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Saturday 21 March 2015 02:55 AM, Arun Ramamurthy wrote:
> > +struct bcm_phy_driver {
> > + void __iomem *usbphy_regs;
> > + void __iomem *usb2h_idm_regs;
> > + void __iomem *usb2d_idm_regs;
> > + struct bcm_phy_instance *ports[MAX_PHY_PORTS];
>
> er.. can't we allocate this dynamically?
The chip has support for only 3 phys, so I believe allocating array of 3
pointers is simplest.
[...]
> > +
> > +static struct phy *bcm_usb_phy_xlate(struct device *dev,
> > + struct of_phandle_args *args)
> > +{
> > + struct bcm_phy_driver *phy_driver = dev_get_drvdata(dev);
> > + struct bcm_phy_instance *port = NULL;
> > + int i;
> > +
> > + if (!phy_driver)
> > + return ERR_PTR(-EINVAL);
> > +
> > + if (WARN_ON(args->args_count != 1))
> > + return ERR_PTR(-EINVAL);
> > +
> > + if (WARN_ON(args->args[0] < 0 || args->args[0] > 1))
> > + return ERR_PTR(-EINVAL);
> > +
> > + for (i = 0; i < ARRAY_SIZE(phy_driver->ports); i++) {
> > + struct bcm_phy_instance *p = phy_driver->ports[i];
> > +
> > + if (p && p->generic_phy->dev.of_node == args->np) {
> > + port = p;
> > + break;
> > + }
> > + }
> > +
> > + if (!port) {
> > + dev_err(dev, "Failed to locate phy %s\n", args->np->name);
> > + return ERR_PTR(-EINVAL);
> > + }
> > +
> > + port->host_mode = args->args[0];
> > +
> > + return port->generic_phy;
> > +}
>
> The xlate function here shouldn't be needed at all. Use of_phy_simple_xlate
> instead.
of_phy_simple_xlate() will not allow specifying host vs device mode when
requesting phy though...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-03-25 22:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 21:25 [PATCH v1 0/3] USB PHY driver for Broadcom's Cygnus chipse Arun Ramamurthy
2015-03-20 21:25 ` [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level Arun Ramamurthy
2015-03-20 21:31 ` Dmitry Torokhov
2015-03-25 22:11 ` Kishon Vijay Abraham I
2015-03-25 22:17 ` Dmitry Torokhov
2015-03-25 22:39 ` Kishon Vijay Abraham I
2015-03-25 22:49 ` Dmitry Torokhov
2015-03-25 23:44 ` Kishon Vijay Abraham I
2015-03-25 23:48 ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 2/3] Phy: DT binding documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
2015-03-25 22:16 ` Kishon Vijay Abraham I
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 23:02 ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver Arun Ramamurthy
2015-03-25 22:28 ` Kishon Vijay Abraham I
2015-03-25 22:42 ` Dmitry Torokhov [this message]
2015-03-26 0:01 ` Kishon Vijay Abraham I
2015-03-26 0:06 ` Arun Ramamurthy
2015-03-31 6:16 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325224253.GA16950@dtor-ws \
--to=dtor@google.com \
--cc=anatol@google.com \
--cc=arnd@arndb.de \
--cc=arun.ramamurthy@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).