From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Huang Ying <ying.huang@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [patch 02/12] mm: oom_kill: clean up victim marking and exiting interfaces
Date: Thu, 26 Mar 2015 12:54:42 +0100 [thread overview]
Message-ID: <20150326115442.GD15257@dhcp22.suse.cz> (raw)
In-Reply-To: <1427264236-17249-3-git-send-email-hannes@cmpxchg.org>
On Wed 25-03-15 02:17:06, Johannes Weiner wrote:
> Rename unmark_oom_victim() to exit_oom_victim(). Marking and
> unmarking are related in functionality, but the interface is not
> symmetrical at all: one is an internal OOM killer function used during
> the killing, the other is for an OOM victim to signal its own death on
> exit later on. This has locking implications, see follow-up changes.
>
> While at it, rename mark_tsk_oom_victim() to mark_oom_victim(), which
> is easier on the eye.
The reason _tsk_ was used was to be in sync with *tsk_thread_flag API.
I do not mind changing that though.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
> ---
> drivers/staging/android/lowmemorykiller.c | 2 +-
> include/linux/oom.h | 7 ++++---
> kernel/exit.c | 2 +-
> mm/memcontrol.c | 2 +-
> mm/oom_kill.c | 16 +++++++---------
> 5 files changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index feafa172b155..2345ee7342d9 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -165,7 +165,7 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
> * infrastructure. There is no real reason why the selected
> * task should have access to the memory reserves.
> */
> - mark_tsk_oom_victim(selected);
> + mark_oom_victim(selected);
> send_sig(SIGKILL, selected, 0);
> rem += selected_tasksize;
> }
> diff --git a/include/linux/oom.h b/include/linux/oom.h
> index 44b2f6f7bbd8..a8e6a498cbcb 100644
> --- a/include/linux/oom.h
> +++ b/include/linux/oom.h
> @@ -47,9 +47,7 @@ static inline bool oom_task_origin(const struct task_struct *p)
> return !!(p->signal->oom_flags & OOM_FLAG_ORIGIN);
> }
>
> -extern void mark_tsk_oom_victim(struct task_struct *tsk);
> -
> -extern void unmark_oom_victim(void);
> +extern void mark_oom_victim(struct task_struct *tsk);
>
> extern unsigned long oom_badness(struct task_struct *p,
> struct mem_cgroup *memcg, const nodemask_t *nodemask,
> @@ -75,6 +73,9 @@ extern enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
>
> extern bool out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
> int order, nodemask_t *mask, bool force_kill);
> +
> +extern void exit_oom_victim(void);
> +
> extern int register_oom_notifier(struct notifier_block *nb);
> extern int unregister_oom_notifier(struct notifier_block *nb);
>
> diff --git a/kernel/exit.c b/kernel/exit.c
> index feff10bbb307..4089c2fd373e 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -436,7 +436,7 @@ static void exit_mm(struct task_struct *tsk)
> mm_update_next_owner(mm);
> mmput(mm);
> if (test_thread_flag(TIF_MEMDIE))
> - unmark_oom_victim();
> + exit_oom_victim();
> }
>
> static struct task_struct *find_alive_thread(struct task_struct *p)
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 74a9641d8f9f..aab5604e0ac4 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1536,7 +1536,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
> * quickly exit and free its memory.
> */
> if (fatal_signal_pending(current) || task_will_free_mem(current)) {
> - mark_tsk_oom_victim(current);
> + mark_oom_victim(current);
> return;
> }
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 73763e489e86..b2f081fe4b1a 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -408,13 +408,13 @@ bool oom_killer_disabled __read_mostly;
> static DECLARE_RWSEM(oom_sem);
>
> /**
> - * mark_tsk_oom_victim - marks the given task as OOM victim.
> + * mark_oom_victim - mark the given task as OOM victim
> * @tsk: task to mark
> *
> * Has to be called with oom_sem taken for read and never after
> * oom has been disabled already.
> */
> -void mark_tsk_oom_victim(struct task_struct *tsk)
> +void mark_oom_victim(struct task_struct *tsk)
> {
> WARN_ON(oom_killer_disabled);
> /* OOM killer might race with memcg OOM */
> @@ -431,11 +431,9 @@ void mark_tsk_oom_victim(struct task_struct *tsk)
> }
>
> /**
> - * unmark_oom_victim - unmarks the current task as OOM victim.
> - *
> - * Wakes up all waiters in oom_killer_disable()
> + * exit_oom_victim - note the exit of an OOM victim
> */
> -void unmark_oom_victim(void)
> +void exit_oom_victim(void)
> {
> if (!test_and_clear_thread_flag(TIF_MEMDIE))
> return;
> @@ -515,7 +513,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
> */
> task_lock(p);
> if (p->mm && task_will_free_mem(p)) {
> - mark_tsk_oom_victim(p);
> + mark_oom_victim(p);
> task_unlock(p);
> put_task_struct(p);
> return;
> @@ -570,7 +568,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
>
> /* mm cannot safely be dereferenced after task_unlock(victim) */
> mm = victim->mm;
> - mark_tsk_oom_victim(victim);
> + mark_oom_victim(victim);
> pr_err("Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB\n",
> task_pid_nr(victim), victim->comm, K(victim->mm->total_vm),
> K(get_mm_counter(victim->mm, MM_ANONPAGES)),
> @@ -728,7 +726,7 @@ static void __out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
> */
> if (current->mm &&
> (fatal_signal_pending(current) || task_will_free_mem(current))) {
> - mark_tsk_oom_victim(current);
> + mark_oom_victim(current);
> return;
> }
>
> --
> 2.3.3
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-03-26 11:54 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 6:17 [patch 00/12] mm: page_alloc: improve OOM mechanism and policy Johannes Weiner
2015-03-25 6:17 ` [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable() Johannes Weiner
2015-03-26 0:51 ` David Rientjes
2015-03-26 11:51 ` Michal Hocko
2015-03-26 13:18 ` Michal Hocko
2015-03-26 19:30 ` David Rientjes
2015-03-26 11:43 ` Michal Hocko
2015-03-26 20:05 ` David Rientjes
2015-03-25 6:17 ` [patch 02/12] mm: oom_kill: clean up victim marking and exiting interfaces Johannes Weiner
2015-03-26 3:34 ` David Rientjes
2015-03-26 11:54 ` Michal Hocko [this message]
2015-03-25 6:17 ` [patch 03/12] mm: oom_kill: switch test-and-clear of known TIF_MEMDIE to clear Johannes Weiner
2015-03-26 3:31 ` David Rientjes
2015-03-26 11:05 ` Johannes Weiner
2015-03-26 19:50 ` David Rientjes
2015-03-30 14:48 ` Michal Hocko
2015-04-02 23:01 ` [patch] android, lmk: avoid setting TIF_MEMDIE if process has already exited David Rientjes
2015-04-28 22:50 ` [patch resend] " David Rientjes
2015-03-26 11:57 ` [patch 03/12] mm: oom_kill: switch test-and-clear of known TIF_MEMDIE to clear Michal Hocko
2015-03-25 6:17 ` [patch 04/12] mm: oom_kill: remove unnecessary locking in exit_oom_victim() Johannes Weiner
2015-03-26 12:53 ` Michal Hocko
2015-03-26 13:01 ` Michal Hocko
2015-03-26 15:10 ` Johannes Weiner
2015-03-26 15:04 ` Johannes Weiner
2015-03-25 6:17 ` [patch 05/12] mm: oom_kill: generalize OOM progress waitqueue Johannes Weiner
2015-03-26 13:03 ` Michal Hocko
2015-03-25 6:17 ` [patch 06/12] mm: oom_kill: simplify OOM killer locking Johannes Weiner
2015-03-26 13:31 ` Michal Hocko
2015-03-26 15:17 ` Johannes Weiner
2015-03-26 16:07 ` Michal Hocko
2015-03-25 6:17 ` [patch 07/12] mm: page_alloc: inline should_alloc_retry() Johannes Weiner
2015-03-26 14:11 ` Michal Hocko
2015-03-26 15:18 ` Johannes Weiner
2015-03-25 6:17 ` [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying Johannes Weiner
2015-03-25 14:15 ` Tetsuo Handa
2015-03-25 17:01 ` Vlastimil Babka
2015-03-26 11:28 ` Johannes Weiner
2015-03-26 11:24 ` Johannes Weiner
2015-03-26 14:32 ` Michal Hocko
2015-03-26 15:23 ` Johannes Weiner
2015-03-26 15:38 ` Michal Hocko
2015-03-26 18:17 ` Johannes Weiner
2015-03-27 14:01 ` [patch 08/12] mm: page_alloc: wait for OOM killer progressbefore retrying Tetsuo Handa
2015-03-26 15:58 ` [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying Michal Hocko
2015-03-26 18:23 ` Johannes Weiner
2015-03-25 6:17 ` [patch 09/12] mm: page_alloc: private memory reserves for OOM-killing allocations Johannes Weiner
2015-04-14 16:49 ` Michal Hocko
2015-04-24 19:13 ` Johannes Weiner
2015-03-25 6:17 ` [patch 10/12] mm: page_alloc: emergency reserve access for __GFP_NOFAIL allocations Johannes Weiner
2015-04-14 16:55 ` Michal Hocko
2015-03-25 6:17 ` [patch 11/12] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM Johannes Weiner
2015-03-26 14:50 ` Michal Hocko
2015-03-25 6:17 ` [patch 12/12] mm: page_alloc: do not lock up low-order " Johannes Weiner
2015-03-26 15:32 ` Michal Hocko
2015-03-26 19:58 ` [patch 00/12] mm: page_alloc: improve OOM mechanism and policy Dave Chinner
2015-03-27 15:05 ` Johannes Weiner
2015-03-30 0:32 ` Dave Chinner
2015-03-30 19:31 ` Johannes Weiner
2015-04-01 15:19 ` Michal Hocko
2015-04-01 21:39 ` Dave Chinner
2015-04-02 7:29 ` Michal Hocko
2015-04-07 14:18 ` Johannes Weiner
2015-04-11 7:29 ` Tetsuo Handa
2015-04-13 12:49 ` Michal Hocko
2015-04-13 12:46 ` Michal Hocko
2015-04-14 0:11 ` Dave Chinner
2015-04-14 7:20 ` Michal Hocko
2015-04-14 10:36 ` Johannes Weiner
2015-04-14 14:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326115442.GD15257@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).