From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbbCZLyM (ORCPT ); Thu, 26 Mar 2015 07:54:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43069 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbbCZLyK (ORCPT ); Thu, 26 Mar 2015 07:54:10 -0400 Date: Thu, 26 Mar 2015 12:53:56 +0100 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, Dave Airlie , Dave Airlie , David Airlie , Rusty Russell , open list , "open list:DRM DRIVERS" , "open list:VIRTIO CORE, NET..." , "open list:ABI/API" Subject: Re: [virtio-dev] Re: [PATCH] Add virtio gpu driver. Message-ID: <20150326124751-mutt-send-email-mst@redhat.com> References: <20150324171255-mutt-send-email-mst@redhat.com> <1427295121.23304.5.camel@nilsson.home.kraxel.org> <20150325162246-mutt-send-email-mst@redhat.com> <1427297836.23304.29.camel@nilsson.home.kraxel.org> <20150325180721-mutt-send-email-mst@redhat.com> <1427353959.9779.2.camel@nilsson.home.kraxel.org> <20150326091545-mutt-send-email-mst@redhat.com> <1427359367.9779.9.camel@nilsson.home.kraxel.org> <20150326095736-mutt-send-email-mst@redhat.com> <1427369923.9779.18.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427369923.9779.18.camel@nilsson.home.kraxel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 12:38:43PM +0100, Gerd Hoffmann wrote: > Hi, > > > Absolutely, it's pretty common to mix regions in a BAR. > > For example, we have virtio kick (ioeventfd backed, > > handled in kernel) in same BAR as common and device > > specific configuration. > > > We did the same thing you are now doing with the > > virtio BAR, and now we have to maintain two code > > bases, virtio pci config was designed to be future proof > > so why not use it? > > It's not about virtio at all. It's about vga compatibility, so we have > a simple framebuffer as boot display. Only used when virtio is *not* > enabled. > I don't know. This seems exactly like the kind of thing we had in mind when we added the virtio pci capability. For example, we have text in spec that requires drivers to skip unknown capabilities. And yes, if bios pokes at a specific bar then we do need to list this info in the virtio spec so this makes it an issue that is virtio related. > > This is mostly just making sure we don't paint ourselves into a corner. > > It's a simple memory bar. vga cards have that since pci was invented > (standalone ones, chipset graphics aside), and there havn't been > fundamental changes ... > > cheers, > Gerd > Yes, it's not about what we put there now. It's about being able to move things about in the future without breaking guests. -- MST