From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbbCZPIl (ORCPT ); Thu, 26 Mar 2015 11:08:41 -0400 Received: from mail-qg0-f43.google.com ([209.85.192.43]:35370 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbbCZPIh (ORCPT ); Thu, 26 Mar 2015 11:08:37 -0400 Date: Thu, 26 Mar 2015 11:08:06 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v6 2/3] cgroups: allow a cgroup subsystem to reject a fork Message-ID: <20150326150806.GB1953@htj.duckdns.org> References: <1426307835-5893-1-git-send-email-cyphar@cyphar.com> <1426307835-5893-3-git-send-email-cyphar@cyphar.com> <20150316165335.GC8353@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 10:25:56PM +1100, Aleksa Sarai wrote: > > Also, what pins the cset between task_css_set() and get_css_set()? > > task_css_set() is protected by RCU and the above should have triggered > > RCU warning if the debug option is enabled. Please always test with > > the debug options enabled, especially the lockdep and RCU ones. > > Debug was enabled AFAIK and I didn't get anything in `dmesg`. I've fixed it > anyway. So, this is worrying. If you have RCU debugging enabled, it should have triggered the warning. If it hadn't, maybe there's something else protecting it and we don't need the extra rcu locking around it. Can you please investigate what's going on? Thanks. -- tejun