From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
u.kleine-koenig@pengutronix.de, afaerber@suse.de,
geert@linux-m68k.org, Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl,
Jonathan Corbet <corbet@lwn.net>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Joe Perches <joe@perches.com>, Antti Palosaari <crope@iki.fi>,
Tejun Heo <tj@kernel.org>, Will Deacon <will.deacon@arm.com>,
Nikolay Borisov <Nikolay.Borisov@arm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Kees Cook <keescook@chromium.org>, Michal Marek <mmarek@suse.cz>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arch@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver
Date: Thu, 26 Mar 2015 15:46:18 +0000 [thread overview]
Message-ID: <20150326154618.GO8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5511ABAA.2010303@hurleysoftware.com>
On Tue, Mar 24, 2015 at 02:23:38PM -0400, Peter Hurley wrote:
> Hi Maxime,
>
> On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
> > +static unsigned int stm32_get_mctrl(struct uart_port *port)
> > +{
> > + /*
> > + * This routine is used for geting signals of: DTR, DCD, DSR, RI,
> > + * and CTS/RTS
It's also worth noting that this comment is wrong. This is used to get
the state of DCD, DSR, RI and CTS. DTR and RTS are *not* included
because the core tracks their state.
...
> > + stm32port->clk = devm_clk_get(&pdev->dev, NULL);
> > +
> > + if (WARN_ON(IS_ERR(stm32port->clk)))
>
> Do you really need a stack trace here? Could this be dev_err() instead?
>
> > + return -EINVAL;
Also, propagate the error code.
> > +
> > + /* ensure that clk rate is correct by enabling the clk */
> > + clk_prepare_enable(stm32port->clk);
And remember to check the return value of clk_prepare_enable().
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-03-26 15:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 21:55 [PATCH v3 00/15] Add support to STMicroelectronics STM32 family Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 01/15] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 02/15] ARM: ARMv7-M: Enlarge vector table up to 256 entries Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 03/15] dt-bindings: Document the ARM System timer bindings Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 04/15] clocksource: Add ARM System timer driver Maxime Coquelin
2015-03-26 9:50 ` Daniel Lezcano
2015-03-26 20:19 ` Maxime Coquelin
2015-03-27 8:36 ` Daniel Lezcano
2015-03-27 12:33 ` Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 05/15] dt-bindings: Document the STM32 reset bindings Maxime Coquelin
2015-03-13 0:09 ` Chanwoo Choi
2015-03-17 16:57 ` Maxime Coquelin
2015-03-13 8:50 ` Philipp Zabel
2015-03-17 17:13 ` Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 06/15] drivers: reset: Add STM32 reset driver Maxime Coquelin
2015-03-13 0:11 ` Chanwoo Choi
2015-03-13 8:54 ` Philipp Zabel
2015-03-17 17:23 ` Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 07/15] dt-bindings: Document the STM32 timer bindings Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 08/15] clockevent: Add STM32 Timer driver Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 09/15] dt-bindings: Document the STM32 USART bindings Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
2015-03-13 9:41 ` Paul Bolle
2015-03-17 17:39 ` Maxime Coquelin
2015-03-13 14:19 ` Andy Shevchenko
2015-03-17 17:32 ` Maxime Coquelin
2015-03-17 17:56 ` Andy Shevchenko
2015-03-19 13:55 ` Maxime Coquelin
2015-03-19 14:58 ` Peter Hurley
2015-03-19 17:35 ` Maxime Coquelin
2015-03-24 17:21 ` Maxime Coquelin
2015-03-24 17:44 ` Peter Hurley
2015-03-24 18:23 ` Peter Hurley
2015-03-26 15:46 ` Russell King - ARM Linux [this message]
2015-03-26 22:05 ` Maxime Coquelin
2015-03-26 22:03 ` Maxime Coquelin
2015-03-27 11:32 ` Peter Hurley
2015-03-27 12:30 ` Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 11/15] ARM: Add STM32 family machine Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 12/15] ARM: dts: Add ARM System timer as clockevent in armv7m Maxime Coquelin
2015-03-12 21:55 ` [PATCH v3 13/15] ARM: dts: Introduce STM32F429 MCU Maxime Coquelin
2015-03-12 21:56 ` [PATCH v3 14/15] ARM: configs: Add STM32 defconfig Maxime Coquelin
2015-03-12 21:56 ` [PATCH v3 15/15] MAINTAINERS: Add entry for STM32 MCUs Maxime Coquelin
2015-03-12 23:45 ` [PATCH v3 00/15] Add support to STMicroelectronics STM32 family Chanwoo Choi
2015-03-18 23:35 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326154618.GO8656@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Nikolay.Borisov@arm.com \
--cc=afaerber@suse.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=crope@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=jslaby@suse.cz \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mmarek@suse.cz \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=peter@hurleysoftware.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).