From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dave Hansen <dave@sr71.net>,
linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
dave.hansen@linux.intel.com
Subject: Re: [PATCH 03/17] x86, mpx: trace #BR exceptions
Date: Fri, 27 Mar 2015 11:21:46 +0100 [thread overview]
Message-ID: <20150327102146.GA18927@pd.tnic> (raw)
In-Reply-To: <20150326183336.DFCBF9C5@viggo.jf.intel.com>
Adding rostedt for the TPs.
Steve, please take a look at the rest of the patchset too, there are
more tracepoints being added.
On Thu, Mar 26, 2015 at 11:33:36AM -0700, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> This is the first in a series of MPX tracing patches.
> I've found these extremely useful in the process of
> debugging applications and the kernel code itself.
>
> This exception hooks in to the bounds (#BR) exception
> very early and allows capturing the key registers which
> would influence how the exception is handled.
>
> Note that bndcfgu/bndstatus are technically still
> 64-bit registers even in 32-bit mode.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> ---
>
> b/arch/x86/include/asm/trace/mpx.h | 48 +++++++++++++++++++++++++++++++++++++
> b/arch/x86/kernel/traps.c | 2 +
> b/arch/x86/mm/mpx.c | 3 ++
> 3 files changed, 53 insertions(+)
>
> diff -puN /dev/null arch/x86/include/asm/trace/mpx.h
> --- /dev/null 2014-10-10 16:10:57.316716958 -0700
> +++ b/arch/x86/include/asm/trace/mpx.h 2015-03-26 11:27:05.444236170 -0700
> @@ -0,0 +1,48 @@
> +#undef TRACE_SYSTEM
> +#define TRACE_SYSTEM mpx
> +
> +#if !defined(_TRACE_MPX_H) || defined(TRACE_HEADER_MULTI_READ)
> +#define _TRACE_MPX_H
> +
> +#include <linux/tracepoint.h>
> +
> +#ifdef CONFIG_X86_INTEL_MPX
> +
> +TRACE_EVENT(bounds_exception_mpx,
> +
> + TP_PROTO(struct bndcsr *bndcsr),
> + TP_ARGS(bndcsr),
> +
> + TP_STRUCT__entry(
> + __field(u64, bndcfgu)
> + __field(u64, bndstatus)
> + ),
> +
> + TP_fast_assign(
> + __entry->bndcfgu = bndcsr->bndcfgu;
> + __entry->bndstatus = bndcsr->bndstatus;
> + ),
> +
> + TP_printk("bndcfgu:0x%llx bndstatus:0x%llx",
> + __entry->bndcfgu,
> + __entry->bndstatus)
> +);
> +
> +#else
> +
> +/*
> + * This gets used outside of MPX-specific code, so we need a stub.
> + */
> +static inline void trace_bounds_exception_mpx(struct bndcsr *bndcsr)
> +{
> +}
> +
> +#endif /* CONFIG_X86_INTEL_MPX */
> +
> +#undef TRACE_INCLUDE_PATH
> +#define TRACE_INCLUDE_PATH asm/trace/
> +#define TRACE_INCLUDE_FILE mpx
> +#endif /* _TRACE_MPX_H */
> +
> +/* This part must be outside protection */
> +#include <trace/define_trace.h>
> diff -puN arch/x86/kernel/traps.c~x86-br-exception-trace arch/x86/kernel/traps.c
> --- a/arch/x86/kernel/traps.c~x86-br-exception-trace 2015-03-26 11:27:05.439235945 -0700
> +++ b/arch/x86/kernel/traps.c 2015-03-26 11:27:05.445236215 -0700
> @@ -61,6 +61,7 @@
> #include <asm/mach_traps.h>
> #include <asm/alternative.h>
> #include <asm/mpx.h>
> +#include <asm/trace/mpx.h>
> #include <asm/xsave.h>
>
> #ifdef CONFIG_X86_64
> @@ -401,6 +402,7 @@ dotraplinkage void do_bounds(struct pt_r
> if (!bndcsr)
> goto exit_trap;
>
> + trace_bounds_exception_mpx(bndcsr);
> /*
> * The error code field of the BNDSTATUS register communicates status
> * information of a bound range exception #BR or operation involving
> diff -puN arch/x86/mm/mpx.c~x86-br-exception-trace arch/x86/mm/mpx.c
> --- a/arch/x86/mm/mpx.c~x86-br-exception-trace 2015-03-26 11:27:05.441236035 -0700
> +++ b/arch/x86/mm/mpx.c 2015-03-26 11:27:05.445236215 -0700
> @@ -18,6 +18,9 @@
> #include <asm/processor.h>
> #include <asm/fpu-internal.h>
>
> +#define CREATE_TRACE_POINTS
> +#include <asm/trace/mpx.h>
> +
> static const char *mpx_mapping_name(struct vm_area_struct *vma)
> {
> return "[mpx]";
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-27 10:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 18:33 [PATCH 00/17] x86, mpx updates for 4.1 (take 2) Dave Hansen
2015-03-26 18:33 ` [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer Dave Hansen
2015-03-27 15:15 ` Borislav Petkov
2015-03-27 16:35 ` Dave Hansen
2015-03-27 18:57 ` Oleg Nesterov
2015-03-26 18:33 ` [PATCH 02/17] x86, mpx: use new tsk_get_xsave_addr() Dave Hansen
2015-03-26 18:33 ` [PATCH 03/17] x86, mpx: trace #BR exceptions Dave Hansen
2015-03-27 10:21 ` Borislav Petkov [this message]
2015-03-26 18:33 ` [PATCH 04/17] x86, mpx: trace entry to bounds exception paths Dave Hansen
2015-03-27 12:02 ` Borislav Petkov
2015-03-26 18:33 ` [PATCH 05/17] x86, mpx: trace when MPX is zapping pages Dave Hansen
2015-03-27 12:26 ` Borislav Petkov
2015-03-26 18:33 ` [PATCH 06/17] x86, mpx: trace attempts to find bounds tables Dave Hansen
2015-03-27 12:32 ` Borislav Petkov
2015-03-27 14:08 ` Dave Hansen
2015-03-26 18:33 ` [PATCH 07/17] x86, mpx: trace allocation of new " Dave Hansen
2015-03-26 18:33 ` [PATCH 08/17] x86, mpx: boot-time disable Dave Hansen
2015-03-27 15:07 ` Borislav Petkov
2015-03-27 15:16 ` Dave Hansen
2015-03-26 18:33 ` [PATCH 09/17] x86: make is_64bit_mm() widely available Dave Hansen
2015-03-26 22:35 ` Andy Lutomirski
2015-03-27 15:21 ` Borislav Petkov
2015-03-26 18:33 ` [PATCH 10/17] x86: make __VIRTUAL_MASK safe to use on 32 bit Dave Hansen
2015-03-26 18:33 ` [PATCH 11/17] x86, mpx: we do not allocate the bounds directory Dave Hansen
2015-03-26 18:33 ` [PATCH 12/17] x86, mpx: remove redundant MPX_BNDCFG_ADDR_MASK Dave Hansen
2015-03-27 17:01 ` Borislav Petkov
2015-03-27 20:45 ` Dave Hansen
2015-03-26 18:33 ` [PATCH 13/17] x86, mpx: Add temporary variable to reduce masking Dave Hansen
2015-03-26 18:33 ` [PATCH 14/17] x86, mpx: new directory entry to addr helper Dave Hansen
2015-03-26 18:33 ` [PATCH 15/17] x86, mpx: do 32-bit-only cmpxchg for 32-bit apps Dave Hansen
2015-03-27 17:29 ` Borislav Petkov
2015-03-27 18:16 ` Dave Hansen
2015-03-28 8:39 ` Borislav Petkov
2015-03-30 16:57 ` Dave Hansen
2015-03-30 16:59 ` Borislav Petkov
2015-03-30 18:58 ` Dave Hansen
2015-03-26 18:33 ` [PATCH 16/17] x86, mpx: support 32-bit binaries on 64-bit kernel Dave Hansen
2015-03-26 18:33 ` [PATCH 17/17] x86, mpx: allow mixed binaries again Dave Hansen
2015-03-27 21:52 [PATCH 00/17] x86, mpx updates for 4.1 (take 3) Dave Hansen
2015-03-27 21:52 ` [PATCH 03/17] x86, mpx: trace #BR exceptions Dave Hansen
2015-03-30 21:25 ` Steven Rostedt
2015-03-30 21:33 ` Dave Hansen
2015-03-30 21:38 ` Steven Rostedt
2015-04-22 18:27 [PATCH 00/17] x86, mpx updates for 4.2 (take 5) Dave Hansen
2015-04-22 18:27 ` [PATCH 03/17] x86, mpx: trace #BR exceptions Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327102146.GA18927@pd.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).